From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Benoit Taine <benoit.taine@lip6.fr>,
Bjorn Helgaas <bhelgaas@google.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: lola: NULL dereference on probe failure
Date: Wed, 10 Dec 2014 14:45:35 +0100 [thread overview]
Message-ID: <s5h7fxz8vpc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20141210130646.GA18593@mwanda>
At Wed, 10 Dec 2014 16:06:46 +0300,
Dan Carpenter wrote:
>
> "card" is NULL if snd_card_new() fails.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c
> index a75c8dc..4cf4be5 100644
> --- a/sound/pci/lola/lola.c
> +++ b/sound/pci/lola/lola.c
> @@ -719,7 +719,7 @@ static int lola_probe(struct pci_dev *pci,
> err = snd_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE,
> 0, &card);
> if (err < 0) {
> - dev_err(card->dev, "Error creating card!\n");
> + dev_err(&pci->dev, "Error creating card!\n");
> return err;
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Benoit Taine <benoit.taine@lip6.fr>,
Bjorn Helgaas <bhelgaas@google.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: lola: NULL dereference on probe failure
Date: Wed, 10 Dec 2014 13:45:35 +0000 [thread overview]
Message-ID: <s5h7fxz8vpc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20141210130646.GA18593@mwanda>
At Wed, 10 Dec 2014 16:06:46 +0300,
Dan Carpenter wrote:
>
> "card" is NULL if snd_card_new() fails.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c
> index a75c8dc..4cf4be5 100644
> --- a/sound/pci/lola/lola.c
> +++ b/sound/pci/lola/lola.c
> @@ -719,7 +719,7 @@ static int lola_probe(struct pci_dev *pci,
> err = snd_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE,
> 0, &card);
> if (err < 0) {
> - dev_err(card->dev, "Error creating card!\n");
> + dev_err(&pci->dev, "Error creating card!\n");
> return err;
> }
>
>
next prev parent reply other threads:[~2014-12-10 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 13:06 [patch] ALSA: lola: NULL dereference on probe failure Dan Carpenter
2014-12-10 13:06 ` Dan Carpenter
2014-12-10 13:06 ` Dan Carpenter
2014-12-10 13:45 ` Takashi Iwai [this message]
2014-12-10 13:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7fxz8vpc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=benoit.taine@lip6.fr \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.