From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Paul Blazejowski <diffie@gmail.com>,
Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Diffie <diffie@blazebox.homeip.net>,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: Re: Linux 2.6.10-rc2
Date: Tue, 16 Nov 2004 10:46:11 +0100 [thread overview]
Message-ID: <s5h7jomdt3w.wl@alsa2.suse.de> (raw)
In-Reply-To: <1100553392.4369.1.camel@krustophenia.net>
At Mon, 15 Nov 2004 16:16:31 -0500,
Lee Revell wrote:
>
> Please report ALSA issues to alsa-devel@lists.sourceforge.net. I have
> added them to the cc:.
The attached patch should fix this.
Takashi
==
Summary: [ALSA] fix sleep in atomic during prepare callback
Fixed the sleep in spinlock during prepare callback.
This happened only on Nforce chips.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
--- linux/sound/pci/intel8x0.c 15 Nov 2004 14:19:52 -0000 1.173
+++ linux/sound/pci/intel8x0.c 16 Nov 2004 09:41:47 -0000
@@ -1020,7 +1020,9 @@ static void snd_intel8x0_setup_pcm_out(i
*/
if (cnt & ICH_PCM_246_MASK) {
iputdword(chip, ICHREG(GLOB_CNT), cnt & ~ICH_PCM_246_MASK);
+ spin_unlock_irq(&chip->reg_lock);
msleep(50); /* grrr... */
+ spin_lock_irq(&chip->reg_lock);
}
} else if (chip->device_type == DEVICE_INTEL_ICH4) {
if (runtime->sample_bits > 16)
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Paul Blazejowski <diffie@gmail.com>,
Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Diffie <diffie@blazebox.homeip.net>,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [Alsa-devel] Re: Linux 2.6.10-rc2
Date: Tue, 16 Nov 2004 10:46:11 +0100 [thread overview]
Message-ID: <s5h7jomdt3w.wl@alsa2.suse.de> (raw)
In-Reply-To: <1100553392.4369.1.camel@krustophenia.net>
At Mon, 15 Nov 2004 16:16:31 -0500,
Lee Revell wrote:
>
> Please report ALSA issues to alsa-devel@lists.sourceforge.net. I have
> added them to the cc:.
The attached patch should fix this.
Takashi
==
Summary: [ALSA] fix sleep in atomic during prepare callback
Fixed the sleep in spinlock during prepare callback.
This happened only on Nforce chips.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
--- linux/sound/pci/intel8x0.c 15 Nov 2004 14:19:52 -0000 1.173
+++ linux/sound/pci/intel8x0.c 16 Nov 2004 09:41:47 -0000
@@ -1020,7 +1020,9 @@ static void snd_intel8x0_setup_pcm_out(i
*/
if (cnt & ICH_PCM_246_MASK) {
iputdword(chip, ICHREG(GLOB_CNT), cnt & ~ICH_PCM_246_MASK);
+ spin_unlock_irq(&chip->reg_lock);
msleep(50); /* grrr... */
+ spin_lock_irq(&chip->reg_lock);
}
} else if (chip->device_type == DEVICE_INTEL_ICH4) {
if (runtime->sample_bits > 16)
next prev parent reply other threads:[~2004-11-16 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 20:23 Linux 2.6.10-rc2 Paul Blazejowski
2004-11-15 21:16 ` Lee Revell
2004-11-15 21:16 ` Lee Revell
2004-11-16 9:46 ` Takashi Iwai [this message]
2004-11-16 9:46 ` [Alsa-devel] " Takashi Iwai
2004-11-18 16:19 ` Bill Davidsen
2004-11-18 16:19 ` [Alsa-devel] " Bill Davidsen
-- strict thread matches above, loose matches on Subject: below --
2004-11-15 2:49 Linus Torvalds
[not found] ` <Pine.LNX.4.58.0411170802500.2222@ppc970.osdl.org>
2004-11-17 19:17 ` Andrew Walrond
2004-11-17 22:33 ` Andrew Walrond
2004-11-17 23:12 ` Linus Torvalds
2004-11-17 23:37 ` Andrew Walrond
2004-11-18 0:12 ` Antonino A. Daplas
2004-11-19 9:06 ` Guido Guenther
2004-11-18 0:01 ` Antonino A. Daplas
2004-11-18 10:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7jomdt3w.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=diffie@blazebox.homeip.net \
--cc=diffie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.