From: Takashi Iwai <tiwai@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size
Date: Mon, 27 Nov 2017 20:51:00 +0100 [thread overview]
Message-ID: <s5h8termrff.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171127125851.10076-1-colin.king@canonical.com>
On Mon, 27 Nov 2017 13:58:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array 'names' on the stack but instead make them static.
> Makes the object code smaller by 50 bytes:
>
> Before:
> text data bss dec hex filename
> 21237 9192 1120 31549 7b3d linux/sound/drivers/dummy.o
>
> After:
> text data bss dec hex filename
> 21095 9280 1120 31495 7b07 linux/sound/drivers/dummy.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size
Date: Mon, 27 Nov 2017 19:51:00 +0000 [thread overview]
Message-ID: <s5h8termrff.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171127125851.10076-1-colin.king@canonical.com>
On Mon, 27 Nov 2017 13:58:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array 'names' on the stack but instead make them static.
> Makes the object code smaller by 50 bytes:
>
> Before:
> text data bss dec hex filename
> 21237 9192 1120 31549 7b3d linux/sound/drivers/dummy.o
>
> After:
> text data bss dec hex filename
> 21095 9280 1120 31495 7b07 linux/sound/drivers/dummy.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size
Date: Mon, 27 Nov 2017 20:51:00 +0100 [thread overview]
Message-ID: <s5h8termrff.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171127125851.10076-1-colin.king@canonical.com>
On Mon, 27 Nov 2017 13:58:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array 'names' on the stack but instead make them static.
> Makes the object code smaller by 50 bytes:
>
> Before:
> text data bss dec hex filename
> 21237 9192 1120 31549 7b3d linux/sound/drivers/dummy.o
>
> After:
> text data bss dec hex filename
> 21095 9280 1120 31495 7b07 linux/sound/drivers/dummy.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2017-11-27 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 12:58 [PATCH] ALSA: drivers: make array 'names' const, reduces object code size Colin King
2017-11-27 14:55 ` walter harms
2017-11-27 14:55 ` walter harms
2017-11-27 15:40 ` Joe Perches
2017-11-27 15:40 ` Joe Perches
2017-11-27 15:40 ` Joe Perches
2017-11-27 16:00 ` walter harms
2017-11-27 16:00 ` walter harms
2017-11-27 17:34 ` Takashi Sakamoto
2017-11-27 17:34 ` Takashi Sakamoto
2017-11-27 17:34 ` Takashi Sakamoto
2017-11-27 19:51 ` Takashi Iwai
2017-11-27 19:51 ` Takashi Iwai
2017-11-27 19:51 ` Takashi Iwai
2017-11-28 10:39 ` Takashi Sakamoto
2017-11-28 10:39 ` Takashi Sakamoto
2017-11-28 10:39 ` Takashi Sakamoto
2017-11-27 19:51 ` Takashi Iwai [this message]
2017-11-27 19:51 ` Takashi Iwai
2017-11-27 19:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8termrff.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.