All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: murray.alex@gmail.com
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - hda 1/1] ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model
Date: Thu, 21 Jan 2010 12:56:38 +0100	[thread overview]
Message-ID: <s5h8wbracy1.wl%tiwai@suse.de> (raw)
In-Reply-To: <4b583eaa.0d0bca0a.753e.37fc@mx.google.com>

At Thu, 21 Jan 2010 22:16:26 +1030,
murray.alex@gmail.com wrote:
> 
> From: Alex Murray <murray.alex@gmail.com>
> 
> 
> Signed-off-by: Alex Murray <murray.alex@gmail.com>
> ---
>  pci/hda/patch_realtek.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/pci/hda/patch_realtek.c b/pci/hda/patch_realtek.c
> index 7e0ea37..d044db9 100644
> --- a/pci/hda/patch_realtek.c
> +++ b/pci/hda/patch_realtek.c
> @@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
>  	 */
>  	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
>  	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
> +	SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5),

Thanks for the patch.
But I wonder whether this entry is really correct.  The value looks
like the codec vendor id.  There you need a PCI SSID.
Did you confirm that your patch really works?


Takashi

  reply	other threads:[~2010-01-21 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21 11:46 [PATCH - hda 1/1] ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model murray.alex
2010-01-21 11:56 ` Takashi Iwai [this message]
2010-01-21 12:37   ` Alex Murray
2010-01-22  9:47     ` Alex Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8wbracy1.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=murray.alex@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.