From: Takashi Iwai <tiwai@suse.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy
Date: Mon, 01 Jun 2009 18:55:23 +0200 [thread overview]
Message-ID: <s5h8wkbc2ro.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090601092354.GN26148@buzzloop.caiaq.de>
At Mon, 1 Jun 2009 11:23:54 +0200,
Daniel Mack wrote:
>
> On Mon, Jun 01, 2009 at 10:32:21AM +0200, Takashi Iwai wrote:
> > > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> >
> > You should use strlcpy() instead of strncpy(). The latter doesn't
> > terminate the oversized string.
>
> Right. Want me to resend or could you do that on the fly while
> commiting?
Well, I'm going to review the whole patches again tomorrow.
Would be nice if you resend the latest fixed ones.
thanks,
Takashi
next prev parent reply other threads:[~2009-06-01 16:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 21:44 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 21:44 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-05-30 21:44 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Daniel Mack
2009-05-30 21:44 ` [PATCH 4/5] ALSA: snd_usb_caiaq: give better longname Daniel Mack
2009-05-30 21:44 ` [PATCH 5/5] ALSA: snd_usb_caiaq: bump version number Daniel Mack
2009-06-01 8:32 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Takashi Iwai
2009-06-01 9:23 ` Daniel Mack
2009-06-01 16:55 ` Takashi Iwai [this message]
2009-06-01 19:36 ` [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-06-01 19:36 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-06-01 19:36 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strlcpy Daniel Mack
2009-06-01 19:36 ` [PATCH 4/5] ALSA: snd_usb_caiaq: give better longname Daniel Mack
2009-06-01 19:36 ` [PATCH 5/5] ALSA: snd_usb_caiaq: bump version number Daniel Mack
2009-06-01 21:09 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Jaroslav Kysela
2009-06-01 23:46 ` Takashi Iwai
2009-06-02 7:29 ` Daniel Mack
2009-06-02 7:49 ` Takashi Iwai
2009-06-02 9:31 ` Daniel Mack
2009-06-02 9:50 ` Takashi Iwai
2009-06-02 9:55 ` Daniel Mack
2009-06-02 10:10 ` [PATCH] ALSA: introduce snd_card_make_id_unique() (was: ALSA: snd_usb_caiaq: give better shortname) Daniel Mack
2009-06-02 10:11 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Jaroslav Kysela
2009-06-02 10:28 ` Daniel Mack
2009-06-02 10:54 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2009-05-30 20:25 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 20:25 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-05-30 20:25 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Daniel Mack
2009-05-30 20:06 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 20:06 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-05-30 20:06 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8wkbc2ro.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.