From: Daniel Mack <daniel@caiaq.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname
Date: Tue, 2 Jun 2009 09:29:49 +0200 [thread overview]
Message-ID: <20090602072948.GO26148@buzzloop.caiaq.de> (raw)
In-Reply-To: <s5hmy8rms9j.wl%tiwai@suse.de>
On Tue, Jun 02, 2009 at 01:46:48AM +0200, Takashi Iwai wrote:
> > > Give the card an 'id' name which will prevent ALSA from calling
> > > choose_default_name(). This implementation only took the last part of a
> > > name containing whitespaces which for example caused 'Audio 4 DJ' to be
> > > shortened to 'DJ', which was not very descriptive.
> > >
> > > The implementation now takes the short name and removes all whitespaces
> > > from it which is much nicer.
> >
> > Unfortunately, this code does not handle id collisions for multiple cards.
>
> Moreover, the id can be passed via a module option. Thus overriding
> the id itself is no good idea.
So what's your suggestion to fix the behaviour I was describing? Maybe a
combination of Jaroslav's collision detection together with a logic that
does not touch the id in case it was passed as module option?
I'm afraid touching choose_default_name() will cause a lot of breakage
for users as their card IDs will suddenly change and former '-D hw:xxx'
syntax won't work anymore.
Daniel
next prev parent reply other threads:[~2009-06-02 7:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 21:44 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 21:44 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-05-30 21:44 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Daniel Mack
2009-05-30 21:44 ` [PATCH 4/5] ALSA: snd_usb_caiaq: give better longname Daniel Mack
2009-05-30 21:44 ` [PATCH 5/5] ALSA: snd_usb_caiaq: bump version number Daniel Mack
2009-06-01 8:32 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Takashi Iwai
2009-06-01 9:23 ` Daniel Mack
2009-06-01 16:55 ` Takashi Iwai
2009-06-01 19:36 ` [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-06-01 19:36 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-06-01 19:36 ` [PATCH 3/5] ALSA: snd_usb_caiaq: use strlcpy Daniel Mack
2009-06-01 19:36 ` [PATCH 4/5] ALSA: snd_usb_caiaq: give better longname Daniel Mack
2009-06-01 19:36 ` [PATCH 5/5] ALSA: snd_usb_caiaq: bump version number Daniel Mack
2009-06-01 21:09 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Jaroslav Kysela
2009-06-01 23:46 ` Takashi Iwai
2009-06-02 7:29 ` Daniel Mack [this message]
2009-06-02 7:49 ` Takashi Iwai
2009-06-02 9:31 ` Daniel Mack
2009-06-02 9:50 ` Takashi Iwai
2009-06-02 9:55 ` Daniel Mack
2009-06-02 10:10 ` [PATCH] ALSA: introduce snd_card_make_id_unique() (was: ALSA: snd_usb_caiaq: give better shortname) Daniel Mack
2009-06-02 10:11 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Jaroslav Kysela
2009-06-02 10:28 ` Daniel Mack
2009-06-02 10:54 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2009-05-30 20:25 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 20:25 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
2009-05-30 21:17 ` Jaroslav Kysela
2009-05-30 21:36 ` Daniel Mack
2009-05-30 20:06 [PATCH 1/5] ALSA: snd_usb_caiaq: clean whitespaces Daniel Mack
2009-05-30 20:06 ` [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602072948.GO26148@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.