Re: [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname

[Daniel Mack <daniel@caiaq.de>]

On Sat, May 30, 2009 at 11:17:08PM +0200, Jaroslav Kysela wrote:
>> ALSA's core will only take the last part of a string from the shortname,
>> hence replace all ' ' by '_'. For example, the card name 'Audio 4 DJ'
>> was shortened to 'DJ' before which doesn't look nice at all.
>>
>> Signed-off-by: Daniel Mack <daniel@caiaq.de>
>
> NAK. It would be better to improve the core function choose_default_id()  
> rather than doing this ugly character mangling in the lowlevel driver or  
> add a function to set ID (card->id) from the lowlevel driver.

Oh yes, you're right. I now realized all I need to do is fill card->id
with something sane, so choose_default_id() won't get called at all.

I'll resend the whole set.

Thanks,
Daniel