All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <Liam.Girdwood@wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/4] AC97 wm9713 support
Date: Thu, 10 Mar 2005 15:36:25 +0100	[thread overview]
Message-ID: <s5h8y4vwot2.wl@alsa2.suse.de> (raw)
In-Reply-To: <1110463992.19036.106.camel@cearnarfon>

At Thu, 10 Mar 2005 14:13:12 +0000,
Liam Girdwood wrote:
> 
> On Thu, 2005-03-10 at 13:26, Takashi Iwai wrote:
> 
> > 
> > The attached is the changed patch:
> > 
> > - only snd_ac97_*_enum_double(), no single callbacks
> > - change the definition of AC97_* macro:
> >   AC97_ENUM_DOUBLE() and AC97_ENUM_SINGLE() defines the enum struct
> >   for double and single channels.
> >   AC97_ENUM() defines the control struct.
> >   (IMO, this is more straightforward.)
> > - WM-specific flags are set in the patch.  Only AC97_DEFAULT_POWER_OFF
> >   is set in ac97_codec.c, which has to be known before the patch.
> > - fix compilation warnings.
> > 
> > 
> > Liam, could you check whether it's OK?
> > 
> 
> Works perfectly·

Thanks for the confirmation.  Now applied to CVS.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

      reply	other threads:[~2005-03-10 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-25 14:23 [PATCH 1/4] AC97 wm9713 support Liam Girdwood
2005-03-10 11:43 ` Takashi Iwai
2005-03-10 13:26   ` Takashi Iwai
2005-03-10 14:13     ` Liam Girdwood
2005-03-10 14:36       ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8y4vwot2.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=Liam.Girdwood@wolfsonmicro.com \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.