Re: [PATCH 1/4] AC97 wm9713 support

[Takashi Iwai <tiwai@suse.de>]

At Fri, 25 Feb 2005 14:23:17 +0000,
Liam Girdwood wrote:
> 
> [1  <text/plain (7bit)>]
> This patch is against ac97_codec.c and includes parts of Takashi's AC97
> low power codec patch posted to lkml on Jan 4th 2005. It also includes
> better enumerated mixer type support.
> 
> Apologies for the size of this patch. This was the minimum changes
> required to get audio in/out of the codec.
> 
> Changes:-
> 
>   o Added WM9713/WM9714 to codec ID table
>   o Removed snd_ac97_[info|get|put]_mux().
>   o Added snd_ac97_[info|get|put]_enum_single() for single channel enums
>   o Added snd_ac97_[info|get|put]_enum_double() for double channel enums
>   o Moved AC97_ENUM_DOUBLE macro to ac97_local.h
>   o Moved AC97_DOUBLE macro to ac97_local.h

How about to create unified enum callbacks for both single and double
channels?  For example, in get/put callback, if shift_l == shift_r,
it's handled as a single control, otherwise double.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click