[PATCH] virmidi: use unsigned 1-bit fields

[PATCH] virmidi: use unsigned 1-bit fields

[Randy.Dunlap]

Can't have a boolean and a sign bit in 1 bit.

Fix (14) boolean/bitfield sparse warning:
include/sound/seq_virmidi.h:41:16: warning: dubious one-bit signed bitfield

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
 include/sound/seq_virmidi.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Naurp ./include/sound/seq_virmidi.h~sound_virmidi_bool ./include/sound/seq_virmidi.h
--- ./include/sound/seq_virmidi.h~sound_virmidi_bool	2004-12-24 13:35:29.000000000 -0800
+++ ./include/sound/seq_virmidi.h	2005-02-15 19:41:09.086122328 -0800
@@ -38,7 +38,7 @@ typedef struct _snd_virmidi {
 	int seq_mode;
 	int client;
 	int port;
-	int trigger: 1;
+	unsigned int trigger: 1;
 	snd_midi_event_t *parser;
 	snd_seq_event_t event;
 	snd_virmidi_dev_t *rdev;


---


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: [PATCH] virmidi: use unsigned 1-bit fields

[Takashi Iwai]

At Wed, 16 Feb 2005 15:55:07 -0800,
Randy.Dunlap wrote:
> 
> Can't have a boolean and a sign bit in 1 bit.
> 
> Fix (14) boolean/bitfield sparse warning:
> include/sound/seq_virmidi.h:41:16: warning: dubious one-bit signed bitfield
> 
> Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

Thanks, applied to CVS.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click