All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604
Date: Fri, 01 Oct 2021 08:58:48 +0200	[thread overview]
Message-ID: <s5ha6jtjknr.wl-tiwai@suse.de> (raw)
In-Reply-To: <YVYSnoQ7nxLXT0Dq@geday>

On Thu, 30 Sep 2021 21:40:14 +0200,
Geraldo Nascimento wrote:
> 
> Hi Takashi,
> 
> Hopefully you will be able to apply this cleanly to branch master of your
> sound.git.
> 
> Thanks!
> Geraldo Nascimento
> 
> ---
> 
> Behringer UFX1204 and UFX1604 have Synchronous endpoints to which
> current ALSA code applies implicit feedback sync as if they were
> Asynchronous endpoints. This breaks UAC compliance and is unneeded.
> 
> The commit 5e35dc0338d85ccebacf3f77eca1e5dea73155e8 and subsequent
> 1a15718b41df026cffd0e42cfdc38a1384ce19f9 were meant to clear up noise.
> 
> Unfortunately, noise persisted for those using higher sample rates and
> this was only solved by commit d2e8f641257d0d3af6e45d6ac2d6f9d56b8ea964
> 
> Since there are no more reports of noise, let's get rid of the
> implicit-fb quirks breaking UAC compliance.
> 
> Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>

Thanks, applied now.


Takashi

      reply	other threads:[~2021-10-01  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 19:40 [PATCH] ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604 Geraldo Nascimento
2021-10-01  6:58 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha6jtjknr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=geraldogabriel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.