From: Takashi Iwai <tiwai@suse.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ALSA: hda: intel-dsp-config: Add FLAG_BYT_FIRST / _SECOND defines
Date: Mon, 08 Feb 2021 11:04:02 +0100 [thread overview]
Message-ID: <s5ha6sezxil.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210208093800.62099-1-hdegoede@redhat.com>
On Mon, 08 Feb 2021 10:37:59 +0100,
Hans de Goede wrote:
>
> Instead of hardcording the SST driver having the highest prio, add
> FLAG_BYT_FIRST and FLAG_BYT_SECOND defines, which get set like this
> when both drivers are enabled:
>
> #define FLAG_BYT_FIRST FLAG_SST
> #define FLAG_BYT_SECOND FLAG_SOF
>
> And when only 1 driver is enabled then FLAG_BYT_FIRST gets set to
> the flag for that driver.
>
> This is a preparation patch for making which driver is preferred
> configurable through Kconfig.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I find the idea is fine, but the ifdef conditions become too complex
after this change. It took minutes to check whether the ifdef changes
are really correct for me :)
So, it'd be appreciated if this can be re-designed and simplified...
Takashi
next prev parent reply other threads:[~2021-02-08 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 9:37 [PATCH 1/2] ALSA: hda: intel-dsp-config: Add FLAG_BYT_FIRST / _SECOND defines Hans de Goede
2021-02-08 9:38 ` [PATCH 2/2] ALSA: hda: intel-dsp-config: Add SND_INTEL_BYT_PREFER_SOF Kconfig option Hans de Goede
2021-02-08 10:04 ` Takashi Iwai [this message]
2021-02-08 10:24 ` [PATCH 1/2] ALSA: hda: intel-dsp-config: Add FLAG_BYT_FIRST / _SECOND defines Hans de Goede
2021-02-08 11:02 ` Takashi Iwai
2021-02-08 11:08 ` Hans de Goede
2021-02-08 11:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha6sezxil.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.