* Re: [alsa-cvslog] CVS: alsa-kernel/pci/hda patch_realtek.c,1.7,1.8 [not found] <E1DWDnF-00080F-Ay@sc8-pr-cvs1.sourceforge.net> @ 2005-05-12 14:50 ` Thierry Vignaud 2005-05-12 15:50 ` Takashi Iwai 0 siblings, 1 reply; 2+ messages in thread From: Thierry Vignaud @ 2005-05-12 14:50 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel Takashi Iwai <tiwai@users.sourceforge.net> writes: > @@ -993,6 +1084,9 @@ > { .modelname = "w810", .config = ALC880_W810 }, > { .pci_vendor = 0x161f, .pci_device = 0x203d, .config = ALC880_W810 }, > > + { .modelname = "z71v", .config = ALC880_Z71V }, > + { .pci_vendor = 0x1043, .pci_device = 0x1964, .config = ALC880_Z71V }, > + > {} > }; why not rename pci_vendor as pci_subvendor and pci_device as pci_subdevice in hda_local.h:hda_board_config ? this would reflect the reality since these pci ids are not the main pci ids but the pci subids. ------------------------------------------------------- This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes! http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [alsa-cvslog] CVS: alsa-kernel/pci/hda patch_realtek.c,1.7,1.8 2005-05-12 14:50 ` [alsa-cvslog] CVS: alsa-kernel/pci/hda patch_realtek.c,1.7,1.8 Thierry Vignaud @ 2005-05-12 15:50 ` Takashi Iwai 0 siblings, 0 replies; 2+ messages in thread From: Takashi Iwai @ 2005-05-12 15:50 UTC (permalink / raw) To: Thierry Vignaud; +Cc: alsa-devel At Thu, 12 May 2005 16:50:12 +0200, Thierry Vignaud wrote: > > Takashi Iwai <tiwai@users.sourceforge.net> writes: > > > @@ -993,6 +1084,9 @@ > > { .modelname = "w810", .config = ALC880_W810 }, > > { .pci_vendor = 0x161f, .pci_device = 0x203d, .config = ALC880_W810 }, > > > > + { .modelname = "z71v", .config = ALC880_Z71V }, > > + { .pci_vendor = 0x1043, .pci_device = 0x1964, .config = ALC880_Z71V }, > > + > > {} > > }; > > why not rename pci_vendor as pci_subvendor and pci_device as > pci_subdevice in hda_local.h:hda_board_config ? > > this would reflect the reality since these pci ids are not the main > pci ids but the pci subids. Done. Takashi ------------------------------------------------------- This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes! http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-12 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1DWDnF-00080F-Ay@sc8-pr-cvs1.sourceforge.net>
2005-05-12 14:50 ` [alsa-cvslog] CVS: alsa-kernel/pci/hda patch_realtek.c,1.7,1.8 Thierry Vignaud
2005-05-12 15:50 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.