All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Sachin Kamat <sachin.kamat@samsung.com>,
	Mark Brown <broonie@kernel.org>, Timur Tabi <timur@tabi.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Xiubo Li <Li.Xiubo@freescale.com>, Sean Cross <xobs@kosagi.com>
Subject: Re: [GIT PULL] ASoC updates for v3.18
Date: Tue, 07 Oct 2014 20:15:08 +0200	[thread overview]
Message-ID: <s5hbnpnlpar.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hfvezlpn9.wl-tiwai@suse.de>

At Tue, 07 Oct 2014 20:07:38 +0200,
Takashi Iwai wrote:
> 
> At Tue, 7 Oct 2014 14:53:12 -0300,
> Fabio Estevam wrote:
> > 
> > Hi Mark/Takashi,
> > 
> > On Tue, Oct 7, 2014 at 2:14 PM, Mark Brown <broonie@kernel.org> wrote:
> > > On Mon, Oct 06, 2014 at 02:37:53PM +0200, Takashi Iwai wrote:
> > >> Mark Brown wrote:
> > >
> > >> However, this resulted in a few new build warnings, and some of them
> > >> look correctly reported.
> > >
> > >> *  sound/soc/codecs/mc13783.c:787:13: warning: 'np' may be used uninitialized in this function [-Wuninitialized]
> > >
> > >> The call of_node_put(np) is done unconditionally even for non-NULL
> > >> pdata where np isn't initialized.  This may lead to a real crash.
> > 
> > Calling of_node_put() with NULL as an argument does not cause crashes.
> > Please check:
> > http://patchwork.ozlabs.org/patch/377930/
> 
> Unless np is uninitialized, it points to a random address.

Oops,

s/uninitialized/initialized/


Takashi

  reply	other threads:[~2014-10-07 18:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06 11:51 [GIT PULL] ASoC updates for v3.18 Mark Brown
2014-10-06 12:37 ` Takashi Iwai
2014-10-06 13:07   ` Mark Brown
2014-10-06 13:12     ` Takashi Iwai
2014-10-06 13:31       ` Mark Brown
2014-10-06 13:36         ` Takashi Iwai
2014-10-07 17:14   ` Mark Brown
2014-10-07 17:53     ` Fabio Estevam
2014-10-07 18:07       ` Takashi Iwai
2014-10-07 18:15         ` Takashi Iwai [this message]
2014-10-07 18:01     ` Nicolin Chen
2014-10-07 18:08       ` Takashi Iwai
2014-10-07 18:12         ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hbnpnlpar.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=sachin.kamat@samsung.com \
    --cc=timur@tabi.org \
    --cc=xobs@kosagi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.