Re: [GIT PULL] ASoC updates for v3.18

[Takashi Iwai <tiwai@suse.de>]

At Mon, 6 Oct 2014 12:51:05 +0100,
Mark Brown wrote:
> 
> The following changes since commit bfe01a5ba2490f299e1d2d5508cbbbadd897bbe9:
> 
>   Linux 3.17 (2014-10-05 12:23:04 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v3.18
> 
> for you to fetch changes up to a5448c88b812390a3622e76d774e10c0da1fb970:
> 
>   Merge remote-tracking branches 'asoc/topic/txx9', 'asoc/topic/wm8978' and 'asoc/topic/wm8994' into asoc-next (2014-10-06 12:49:09 +0100)
> 
> ----------------------------------------------------------------
> ASoC: Updates for v3.18
> 
>  - More componentisation work from Lars-Peter, this time mainly
>    cleaning up the suspend and bias level transition callbacks.
>  - Real system support for the Intel drivers and a bunch of fixes and
>    enhancements for the associated CODEC drivers, this is going to need
>    a lot quirks over time due to the lack of any firmware description of
>    the boards.
>  - Jack detect support for simple card from Dylan Reid.
>  - A bunch of small fixes and enhancements for the Freescale drivers.
>  - New drivers for Analog Devices SSM4567, Cirrus Logic CS35L32, Everest
>    Semiconductor ES8328 and Freescale cards using the ASRC in newer i.MX
>    processors.

Thanks, pulled now.

However, this resulted in a few new build warnings, and some of them
look correctly reported.

*  sound/soc/codecs/mc13783.c:787:13: warning: 'np' may be used uninitialized in this function [-Wuninitialized]

The call of_node_put(np) is done unconditionally even for non-NULL
pdata where np isn't initialized.  This may lead to a real crash.

* sound/soc/fsl/eukrea-tlv320.c:221:14: warning: 'ssi_np' may be used uninitialized in this function [-Wuninitialized]

A similar bug: of_node_put(ssi_np) is reached even before ssi_np is
initialized.

* sound/soc/fsl/imx-es8328.c:196:13: warning: 'codec_np' may be used uninitialized in this function [-Wuninitialized]
* sound/soc/fsl/imx-es8328.c:195:13: warning: 'ssi_np' may be used uninitialized in this function [-Wuninitialized]

Ditto. 


Relevant people put in Cc.  I hope I'll get a new pull request soon
later :)


thanks,

Takashi