All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH] [snd-usb-audio] Add match for JMTek USB sound	card
Date: Mon, 12 Oct 2009 08:32:54 +0200	[thread overview]
Message-ID: <s5hbpkdf7ft.wl%tiwai@suse.de> (raw)
In-Reply-To: <1255173329-20485-1-git-send-email-lkundrak@v3.sk>

At Sat, 10 Oct 2009 13:15:29 +0200,
Lubomir Rintel wrote:
> 
> Entry for JMTek LLC., SSS USB Headphone Set in the quirk table.

The change look OK (suppose it was tested :)

Could you give your sign-off to merge to the upstream?


thanks,

Takashi

> ---
>  sound/usb/usbquirks.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
> index f6f201e..e98ff4c 100644
> --- a/sound/usb/usbquirks.h
> +++ b/sound/usb/usbquirks.h
> @@ -80,6 +80,19 @@
>  	.bInterfaceClass = USB_CLASS_AUDIO,
>  },
>  
> +/* JMTek, LLC. SSS USB Headphone Set */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> +		       USB_DEVICE_ID_MATCH_DEV_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> +	.idVendor = 0x0c76,
> +	.idProduct = 0x1605,
> +	.bDeviceClass = USB_CLASS_PER_INTERFACE,
> +	.bInterfaceClass = USB_CLASS_AUDIO,
> +	.bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
> +},
> +
>  /*
>   * Logitech QuickCam: bDeviceClass is vendor-specific, so generic interface
>   * class matches do not take effect without an explicit ID match.
> -- 
> 1.6.5.rc2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] [snd-usb-audio] Add match for JMTek USB sound	card
Date: Mon, 12 Oct 2009 06:32:54 +0000	[thread overview]
Message-ID: <s5hbpkdf7ft.wl%tiwai@suse.de> (raw)
In-Reply-To: <1255173329-20485-1-git-send-email-lkundrak@v3.sk>

At Sat, 10 Oct 2009 13:15:29 +0200,
Lubomir Rintel wrote:
> 
> Entry for JMTek LLC., SSS USB Headphone Set in the quirk table.

The change look OK (suppose it was tested :)

Could you give your sign-off to merge to the upstream?


thanks,

Takashi

> ---
>  sound/usb/usbquirks.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
> index f6f201e..e98ff4c 100644
> --- a/sound/usb/usbquirks.h
> +++ b/sound/usb/usbquirks.h
> @@ -80,6 +80,19 @@
>  	.bInterfaceClass = USB_CLASS_AUDIO,
>  },
>  
> +/* JMTek, LLC. SSS USB Headphone Set */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> +		       USB_DEVICE_ID_MATCH_DEV_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> +	.idVendor = 0x0c76,
> +	.idProduct = 0x1605,
> +	.bDeviceClass = USB_CLASS_PER_INTERFACE,
> +	.bInterfaceClass = USB_CLASS_AUDIO,
> +	.bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
> +},
> +
>  /*
>   * Logitech QuickCam: bDeviceClass is vendor-specific, so generic interface
>   * class matches do not take effect without an explicit ID match.
> -- 
> 1.6.5.rc2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] [snd-usb-audio] Add match for JMTek USB sound	card
Date: Mon, 12 Oct 2009 08:32:54 +0200	[thread overview]
Message-ID: <s5hbpkdf7ft.wl%tiwai@suse.de> (raw)
In-Reply-To: <1255173329-20485-1-git-send-email-lkundrak@v3.sk>

At Sat, 10 Oct 2009 13:15:29 +0200,
Lubomir Rintel wrote:
> 
> Entry for JMTek LLC., SSS USB Headphone Set in the quirk table.

The change look OK (suppose it was tested :)

Could you give your sign-off to merge to the upstream?


thanks,

Takashi

> ---
>  sound/usb/usbquirks.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
> index f6f201e..e98ff4c 100644
> --- a/sound/usb/usbquirks.h
> +++ b/sound/usb/usbquirks.h
> @@ -80,6 +80,19 @@
>  	.bInterfaceClass = USB_CLASS_AUDIO,
>  },
>  
> +/* JMTek, LLC. SSS USB Headphone Set */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> +		       USB_DEVICE_ID_MATCH_DEV_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> +	.idVendor = 0x0c76,
> +	.idProduct = 0x1605,
> +	.bDeviceClass = USB_CLASS_PER_INTERFACE,
> +	.bInterfaceClass = USB_CLASS_AUDIO,
> +	.bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
> +},
> +
>  /*
>   * Logitech QuickCam: bDeviceClass is vendor-specific, so generic interface
>   * class matches do not take effect without an explicit ID match.
> -- 
> 1.6.5.rc2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2009-10-12  6:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 11:15 [PATCH] [snd-usb-audio] Add match for JMTek USB sound card Lubomir Rintel
2009-10-10 11:15 ` Lubomir Rintel
2009-10-12  6:32 ` Takashi Iwai [this message]
2009-10-12  6:32   ` [alsa-devel] " Takashi Iwai
2009-10-12  6:32   ` Takashi Iwai
2009-10-12  6:42   ` [PATCH] " Lubomir Rintel
2009-10-12  6:42     ` Lubomir Rintel
2009-10-12  6:46     ` Takashi Iwai
2009-10-12  6:46       ` Takashi Iwai
2009-10-12  6:46       ` Takashi Iwai
2009-10-12  6:46 ` [PATCH] [snd-usb-audio] " Clemens Ladisch
2009-10-12  6:46   ` Clemens Ladisch
2009-10-12  6:46   ` Clemens Ladisch
2009-10-12  7:18   ` Takashi Iwai
2009-10-12  7:18     ` Takashi Iwai
2009-10-12  7:18     ` Takashi Iwai
2009-10-12  8:03     ` Lubomir Rintel
2009-10-12  8:03       ` Lubomir Rintel
2009-10-12  8:08       ` Takashi Iwai
2009-10-12  8:08         ` Takashi Iwai
2009-10-12  8:08         ` Takashi Iwai
2009-10-18 16:37         ` Lubomir Rintel
2009-10-18 16:37           ` Lubomir Rintel
2009-10-30 10:29           ` Takashi Iwai
2009-10-30 10:29             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hbpkdf7ft.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.