Re: Same PCI ID, different cards - rfc

[Takashi Iwai <tiwai@suse.de>]

At Sun, 17 Apr 2005 17:25:29 +0200,
Giuliano Pochini wrote:
> 
> 
> 
> I did some work in order to solve the problem about the Gina3G and the
> Layla3G which share the same PCI card so it's impossible to say what card is
> installed before probing.
> 
> The main difference between the two cards is the number of channels. I added
> those data in chip_t and I replaced the related macros with inline functions
> (defined in echoaudio.h). Those functions return a constant for all non-3G
> cards, so no overhead is added. The patch has been tested on my Gina24 and
> Gina3G only. It's quite big because it touches a lot of code and it replaces
> a few files but the relevant changes are only in echoaudio.h, echo3g.c and
> echo3g_dsp.c .
> 
> http://xoomer.virgilio.it/g_pochini/e3g.patch

The patch looks fine.
Could you give me the summary and signed-off-by as usual?

Thanks for your work!


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728