Same PCI ID, different cards - rfc

Same PCI ID, different cards - rfc

[Giuliano Pochini]

I did some work in order to solve the problem about the Gina3G and the
Layla3G which share the same PCI card so it's impossible to say what card is
installed before probing.

The main difference between the two cards is the number of channels. I added
those data in chip_t and I replaced the related macros with inline functions
(defined in echoaudio.h). Those functions return a constant for all non-3G
cards, so no overhead is added. The patch has been tested on my Gina24 and
Gina3G only. It's quite big because it touches a lot of code and it replaces
a few files but the relevant changes are only in echoaudio.h, echo3g.c and
echo3g_dsp.c .

http://xoomer.virgilio.it/g_pochini/e3g.patch


--
Giuliano.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: Same PCI ID, different cards - rfc

[Takashi Iwai]

At Sun, 17 Apr 2005 17:25:29 +0200,
Giuliano Pochini wrote:
> 
> 
> 
> I did some work in order to solve the problem about the Gina3G and the
> Layla3G which share the same PCI card so it's impossible to say what card is
> installed before probing.
> 
> The main difference between the two cards is the number of channels. I added
> those data in chip_t and I replaced the related macros with inline functions
> (defined in echoaudio.h). Those functions return a constant for all non-3G
> cards, so no overhead is added. The patch has been tested on my Gina24 and
> Gina3G only. It's quite big because it touches a lot of code and it replaces
> a few files but the relevant changes are only in echoaudio.h, echo3g.c and
> echo3g_dsp.c .
> 
> http://xoomer.virgilio.it/g_pochini/e3g.patch

The patch looks fine.
Could you give me the summary and signed-off-by as usual?

Thanks for your work!


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728

Re: Same PCI ID, different cards - rfc

[Giuliano Pochini]

On Tue, 19 Apr 2005 14:57:52 +0200
Takashi Iwai <tiwai@suse.de> wrote:

> At Sun, 17 Apr 2005 17:25:29 +0200,
> Giuliano Pochini wrote:
> > 
> > I did some work in order to solve the problem about the Gina3G and the
> > Layla3G which share the same PCI card so it's impossible to say what card is
> > installed before probing.
> > 
> > The main difference between the two cards is the number of channels. I added
> > those data in chip_t and I replaced the related macros with inline functions
> > (defined in echoaudio.h). Those functions return a constant for all non-3G
> > cards, so no overhead is added. The patch has been tested on my Gina24 and
> > Gina3G only. It's quite big because it touches a lot of code and it replaces
> > a few files but the relevant changes are only in echoaudio.h, echo3g.c and
> > echo3g_dsp.c .
> > 
> > http://xoomer.virgilio.it/g_pochini/e3g.patch
> 
> The patch looks fine.
> Could you give me the summary and signed-off-by as usual?



Ok, This is a slightly modified patch. There is a small bugfix, it removes
some no more used #define's and it doesn't contain the "return err" fix that
has already been merged.



- This patch unifies the Gina3G and the Layla3G drivers. The new driver is
called snd-echo3g.


Signed-off-by: Giuliano Pochini <pochini@shiny.it>

http://xoomer.virgilio.it/g_pochini/echo3g.patch




--
Giuliano.


-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728

Re: Same PCI ID, different cards - rfc

[Takashi Iwai]

At Tue, 19 Apr 2005 20:37:05 +0200,
Giuliano Pochini wrote:
> 
> On Tue, 19 Apr 2005 14:57:52 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
> > At Sun, 17 Apr 2005 17:25:29 +0200,
> > Giuliano Pochini wrote:
> > > 
> > > I did some work in order to solve the problem about the Gina3G and the
> > > Layla3G which share the same PCI card so it's impossible to say what card is
> > > installed before probing.
> > > 
> > > The main difference between the two cards is the number of channels. I added
> > > those data in chip_t and I replaced the related macros with inline functions
> > > (defined in echoaudio.h). Those functions return a constant for all non-3G
> > > cards, so no overhead is added. The patch has been tested on my Gina24 and
> > > Gina3G only. It's quite big because it touches a lot of code and it replaces
> > > a few files but the relevant changes are only in echoaudio.h, echo3g.c and
> > > echo3g_dsp.c .
> > > 
> > > http://xoomer.virgilio.it/g_pochini/e3g.patch
> > 
> > The patch looks fine.
> > Could you give me the summary and signed-off-by as usual?
> 
> 
> 
> Ok, This is a slightly modified patch. There is a small bugfix, it removes
> some no more used #define's and it doesn't contain the "return err" fix that
> has already been merged.
> 
> 
> 
> - This patch unifies the Gina3G and the Layla3G drivers. The new driver is
> called snd-echo3g.
> 
> 
> Signed-off-by: Giuliano Pochini <pochini@shiny.it>
> 
> http://xoomer.virgilio.it/g_pochini/echo3g.patch

Thanks, applied now.  I modified the description in INSTALL, too.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728