envy24control and gtk2

envy24control and gtk2

[Søren Wedel Nielsen]

Hi,

I have upgraded the envy24control program to use gtk2.
To make the layout work I have changed it from fixed to hbox/vbox, but I
have tried not to change the structure og the gui-file envy24control.c.
It will also work with gtk1.

http://www.heko.dk/~swn/envy24control/envy24control-hboxvbox-230303.patch

To get it to use gtk2 I have changed the build configuration files.

http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch


Søren Wedel Nielsen



-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open!
Get cracking and register here for some mind boggling fun and
the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en

Re: envy24control and gtk2

[Takashi Iwai]

Hi,

At 24 Mar 2003 00:30:43 +0100,
Søren Wedel Nielsen wrote:
> 
> Hi,
> 
> I have upgraded the envy24control program to use gtk2.
> To make the layout work I have changed it from fixed to hbox/vbox, but I
> have tried not to change the structure og the gui-file envy24control.c.
> It will also work with gtk1.
> 
> http://www.heko.dk/~swn/envy24control/envy24control-hboxvbox-230303.patch

thanks, i applied this to cvs.


> To get it to use gtk2 I have changed the build configuration files.
> 
> http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch

this is not yet - i suppose many users still stick with gtk1.2.
would it be better to put the patch on cvs?


Takashi


-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

Re: envy24control and gtk2

[Søren Wedel Nielsen]

tir, 2003-03-25 kl. 18:39 skrev Takashi Iwai:
> Hi,
> 
> > To get it to use gtk2 I have changed the build configuration files.
> > 
> > http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch
> 
> this is not yet - i suppose many users still stick with gtk1.2.
> would it be better to put the patch on cvs?
> 
> 
> Takashi

That would be fine. 

I could also try to figure out if it is possible to make it an option to 
the configure script. 
I am not at very friendly terms with the autotools, so please put the 
patch in for now.

Søren



-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

Re: envy24control and gtk2

[Fernando Pablo Lopez-Lezcano]

> > I have upgraded the envy24control program to use gtk2.
> > To make the layout work I have changed it from fixed to hbox/vbox, but I
> > have tried not to change the structure og the gui-file envy24control.c.
> > It will also work with gtk1.
> > 
> > http://www.heko.dk/~swn/envy24control/envy24control-hboxvbox-230303.patch
> 
> thanks, i applied this to cvs.
> 
> > To get it to use gtk2 I have changed the build configuration files.
> > 
> > http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch
> 
> this is not yet - i suppose many users still stick with gtk1.2.
> would it be better to put the patch on cvs?

Is this an option or mandatory? Will the program still build on gtk1.2?
Otherwise (for example) users of redhat 7.2 will not be able to compile
envy24control...

-- Fernando




-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

Re: envy24control and gtk2

[Søren Wedel Nielsen]

tir, 2003-03-25 kl. 20:41 skrev Fernando Pablo Lopez-Lezcano:
> > > I have upgraded the envy24control program to use gtk2.
> > > To make the layout work I have changed it from fixed to hbox/vbox, but I
> > > have tried not to change the structure og the gui-file envy24control.c.
> > > It will also work with gtk1.
> > > 
> > > http://www.heko.dk/~swn/envy24control/envy24control-hboxvbox-230303.patch
> > 
> > thanks, i applied this to cvs.
> > 
> > > To get it to use gtk2 I have changed the build configuration files.
> > > 
> > > http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch
> > 
> > this is not yet - i suppose many users still stick with gtk1.2.
> > would it be better to put the patch on cvs?
> 
> Is this an option or mandatory? Will the program still build on gtk1.2?
> Otherwise (for example) users of redhat 7.2 will not be able to compile
> envy24control...
> 
> -- Fernando

For now the program will compile with gtk1 unless you apply the second
patch yourself. I will try to make it use gtk2 as default and fall back
to gtk1 if gtk2 is not present.

Søren



-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

Re: envy24control and gtk2

[Takashi Iwai]

At 25 Mar 2003 20:51:07 +0100,
Søren Wedel Nielsen wrote:
> 
> tir, 2003-03-25 kl. 20:41 skrev Fernando Pablo Lopez-Lezcano:
> > > > I have upgraded the envy24control program to use gtk2.
> > > > To make the layout work I have changed it from fixed to hbox/vbox, but I
> > > > have tried not to change the structure og the gui-file envy24control.c.
> > > > It will also work with gtk1.
> > > > 
> > > > http://www.heko.dk/~swn/envy24control/envy24control-hboxvbox-230303.patch
> > > 
> > > thanks, i applied this to cvs.
> > > 
> > > > To get it to use gtk2 I have changed the build configuration files.
> > > > 
> > > > http://www.heko.dk/~swn/envy24control/envy24control-gtk2-230303.patch
> > > 
> > > this is not yet - i suppose many users still stick with gtk1.2.
> > > would it be better to put the patch on cvs?
> > 
> > Is this an option or mandatory? Will the program still build on gtk1.2?
> > Otherwise (for example) users of redhat 7.2 will not be able to compile
> > envy24control...
> > 
> > -- Fernando
> 
> For now the program will compile with gtk1 unless you apply the second
> patch yourself. I will try to make it use gtk2 as default and fall back
> to gtk1 if gtk2 is not present.

please note that, so far, we still don't define pkgconfig as default
requirement for alsa-tools package...
although i prefer pkgconfig, there are still old systems which don't
have it.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

Re: envy24control and gtk2

[Søren Wedel Nielsen]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

ons, 2003-03-26 kl. 10:13 skrev Takashi Iwai:

> > For now the program will compile with gtk1 unless you apply the second
> > patch yourself. I will try to make it use gtk2 as default and fall back
> > to gtk1 if gtk2 is not present.
> 
> please note that, so far, we still don't define pkgconfig as default
> requirement for alsa-tools package...
> although i prefer pkgconfig, there are still old systems which don't
> have it.

On a computer with pkgconfig autoconf will generate a configure script
that will first try gtk2 and if that fails it will use gtk1.
On a computer without pkgconfig you will get a configure script that
will allways use gtk1.

The configure script is a little (too?) ugly, but I think it works
though I have not been able to test all combinations fully.
Maybee it is better to keep the patch??? 


Søren

[-- Attachment #2: configure.in --]
[-- Type: text/plain, Size: 881 bytes --]

AC_INIT(envy24control.c)
AM_INIT_AUTOMAKE(envy24control, 0.1.0)
AC_PROG_CC
AC_PROG_INSTALL
AC_HEADER_STDC

ALSA_REQUIRED=0.9.0

ifdef([PKG_CHECK_MODULES],
      [echo "GTK2"
       PKG_CHECK_MODULES(
         ENVY24CONTROL, 
         gtk+-2.0 alsa >= $ALSA_REQUIRED,[],
         [echo GTK1
          AM_PATH_GTK(1.0.1)
          AM_PATH_ALSA($ALSA_REQUIRED)
          CFLAGS="$CFLAGS $GTK_CFLAGS $ALSA_FLAGS"
          LDFLAGS="$LDFLAGS $GTK_LIBS $ALSA_LIBS"
          ENVY24CONTROL_CFLAGS="$CFLAGS"
          ENVY24CONTROL_LIBS="$GTK_LIBS"])],
      [echo GTK1
       AM_PATH_GTK(1.0.1)
       AM_PATH_ALSA($ALSA_REQUIRED)
       CFLAGS="$CFLAGS $GTK_CFLAGS $ALSA_FLAGS"
       LDFLAGS="$LDFLAGS $GTK_LIBS $ALSA_LIBS"
       ENVY24CONTROL_CFLAGS="$CFLAGS"
       ENVY24CONTROL_LIBS="$GTK_LIBS"]])


AC_SUBST(ENVY24CONTROL_CFLAGS)
AC_SUBST(ENVY24CONTROL_LIBS)

AC_OUTPUT(Makefile)

[-- Attachment #3: Makefile.am --]
[-- Type: text/x-makefile, Size: 523 bytes --]

INCLUDES=\
    @ENVY24CONTROL_CFLAGS@

bin_PROGRAMS = envy24control
man_MANS = envy24control.1
envy24control_SOURCES = envy24control.c envy24control.h levelmeters.c \
                        mixer.c patchbay.c hardware.c driverevents.c volume.c
envy24control_LDFLAGS = $(ENVY24CONTROL_LIBS)
EXTRA_DIST = cvscompile envy24control.1 depcomp

clean:
	rm -rf .deps *~

alsa-dist: distdir
	@rm -rf ../distdir/envy24control
	@mkdir -p ../distdir/envy24control
	@cp -RLpv $(distdir)/* ../distdir/envy24control
	@rm -rf $(distdir)