All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Benny Sjostrand <gorm@cucumelo.org>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] cs46xx, independant rear PCM channel, IEC958 PCM channel
Date: Wed, 30 Oct 2002 19:19:49 +0100	[thread overview]
Message-ID: <s5hbs5bbxh6.wl@alsa2.suse.de> (raw)
In-Reply-To: <3DBE3EDA.80900@cucumelo.org>

Hi Benny,

the changes look ok, but i'd like to ask your favor before applying
this patch.

could you move the SCB initialization part in
cs46xx_playback_prepare() into hw_params callback?
i found that the mutex is not allowed in prepare callback since it's
protected by spinlock (at the very entry of prepare action).
this caused oops on 2.5.x kernels, as you might have seen a report on
alsa-devel ML.

please note that hw_params callback may be called also not only once,
so you'll need to check whether the SCB was already initialized, and
release the old allocation before re-initializing.

also, it would be appreciated if you fix the whitespaces :)


ciao,

Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

  parent reply	other threads:[~2002-10-30 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-29  7:55 [PATCH] cs46xx, independant rear PCM channel, IEC958 PCM channel Benny Sjostrand
2002-10-29 15:14 ` Peter Heatwole
2002-10-30 18:19 ` Takashi Iwai [this message]
2002-10-30 22:25   ` Benny Sjostrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hbs5bbxh6.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=gorm@cucumelo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.