All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Matthew Ranostay <mranostay@embeddedalley.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] hda: Add STAC92HD83XXX_PWR_REF quirk
Date: Thu, 22 Jan 2009 14:27:04 +0100	[thread overview]
Message-ID: <s5hd4eftqs7.wl%tiwai@suse.de> (raw)
In-Reply-To: <49787337.3030406@embeddedalley.com>

At Thu, 22 Jan 2009 08:23:03 -0500,
Matthew Ranostay wrote:
> 
> Takashi Iwai wrote:
> > At Wed, 21 Jan 2009 17:39:43 -0500,
> > Matthew Ranostay wrote:
> >> @@ -334,7 +335,7 @@ static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
> >>  };
> >>  
> >>  static unsigned int stac92hd83xxx_pwr_mapping[4] = {
> >> -	0x03, 0x0c, 0x20, 0x80,
> >> +	0x03, 0x0c, 0x20, 0x40,
> >>  };
> > 
> > What is this change?
> > 
> >
> From my patch before I made a mistake, somehow I thought port 0xe was 0xf in that
> change. Sorry for the inconvenience.

Well, if it's needed to be fixed, please create another patch, since
this change is basically independent from PWR_REF quirk.
Or, at least, include some proper description in changelog.


thanks,

Takashi

  reply	other threads:[~2009-01-22 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 22:39 [PATCH] hda: Add STAC92HD83XXX_PWR_REF quirk Matthew Ranostay
2009-01-22  6:43 ` Takashi Iwai
2009-01-22 13:23   ` Matthew Ranostay
2009-01-22 13:27     ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-23  1:53 Matthew Ranostay
2009-01-23  7:45 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd4eftqs7.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mranostay@embeddedalley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.