All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: James Courtier-Dutton <James@superbug.co.uk>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] SB Live24bit: Adds support for SPDIF in.
Date: Mon, 20 Dec 2004 12:41:45 +0100	[thread overview]
Message-ID: <s5hd5x5w612.wl@alsa2.suse.de> (raw)
In-Reply-To: <41C5EC53.70809@superbug.co.uk>

At Sun, 19 Dec 2004 21:02:11 +0000,
James Courtier-Dutton wrote:
> 
> -static int snd_ca0106_pcm_open_capture(snd_pcm_substream_t *substream)
> +static int snd_ca0106_pcm_open_0_capture(snd_pcm_substream_t *substream)
>  {
>  	return snd_ca0106_pcm_open_capture_channel(substream, 0);
>  }

You can retrieve substream->pcm->device instead of creating a callback
for each device.  (Or, substream->number if the pcm has multiple
substreams and you need to distinguish them.)
Other stuff looks fine to me.

Oh one thing forgotten:  could you provide signed-off-by line, too?


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

      reply	other threads:[~2004-12-20 11:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-19 21:02 [PATCH] SB Live24bit: Adds support for SPDIF in James Courtier-Dutton
2004-12-20 11:41 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd5x5w612.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=James@superbug.co.uk \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.