* [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static
@ 2004-11-21 23:58 Adrian Bunk
2004-11-22 18:59 ` [Alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2004-11-21 23:58 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, linux-kernel
The patch below makes some needlessly global code static.
diffstat output:
sound/pcmcia/pdaudiocf/pdaudiocf.h | 2 --
sound/pcmcia/pdaudiocf/pdaudiocf_core.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf.h.old 2004-11-21 23:57:28.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf.h 2004-11-21 23:57:46.000000000 +0100
@@ -130,8 +130,6 @@
return inw(chip->port + reg);
}
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg);
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val);
pdacf_t *snd_pdacf_create(snd_card_t *card);
int snd_pdacf_ak4117_create(pdacf_t *pdacf);
void snd_pdacf_powerdown(pdacf_t *chip);
--- linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf_core.c.old 2004-11-21 23:57:54.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf_core.c 2004-11-21 23:58:10.000000000 +0100
@@ -28,7 +28,7 @@
/*
*
*/
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
+static unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
{
pdacf_t *chip = private_data;
unsigned long timeout;
@@ -60,7 +60,7 @@
return res;
}
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
+static void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
{
pdacf_t *chip = private_data;
unsigned long timeout;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static
2004-11-21 23:58 [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static Adrian Bunk
@ 2004-11-22 18:59 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2004-11-22 18:59 UTC (permalink / raw)
To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel
At Mon, 22 Nov 2004 00:58:53 +0100,
Adrian Bunk wrote:
>
> The patch below makes some needlessly global code static.
>
>
> diffstat output:
> sound/pcmcia/pdaudiocf/pdaudiocf.h | 2 --
> sound/pcmcia/pdaudiocf/pdaudiocf_core.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, I applied to ALSA CVS.
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Alsa-devel] [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static
@ 2004-11-22 18:59 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2004-11-22 18:59 UTC (permalink / raw)
To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel
At Mon, 22 Nov 2004 00:58:53 +0100,
Adrian Bunk wrote:
>
> The patch below makes some needlessly global code static.
>
>
> diffstat output:
> sound/pcmcia/pdaudiocf/pdaudiocf.h | 2 --
> sound/pcmcia/pdaudiocf/pdaudiocf_core.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, I applied to ALSA CVS.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static
@ 2004-11-21 23:58 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2004-11-21 23:58 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, linux-kernel
The patch below makes some needlessly global code static.
diffstat output:
sound/pcmcia/pdaudiocf/pdaudiocf.h | 2 --
sound/pcmcia/pdaudiocf/pdaudiocf_core.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf.h.old 2004-11-21 23:57:28.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf.h 2004-11-21 23:57:46.000000000 +0100
@@ -130,8 +130,6 @@
return inw(chip->port + reg);
}
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg);
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val);
pdacf_t *snd_pdacf_create(snd_card_t *card);
int snd_pdacf_ak4117_create(pdacf_t *pdacf);
void snd_pdacf_powerdown(pdacf_t *chip);
--- linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf_core.c.old 2004-11-21 23:57:54.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/sound/pcmcia/pdaudiocf/pdaudiocf_core.c 2004-11-21 23:58:10.000000000 +0100
@@ -28,7 +28,7 @@
/*
*
*/
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
+static unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
{
pdacf_t *chip = private_data;
unsigned long timeout;
@@ -60,7 +60,7 @@
return res;
}
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
+static void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
{
pdacf_t *chip = private_data;
unsigned long timeout;
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-22 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-21 23:58 [2.6 patch] ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static Adrian Bunk
2004-11-22 18:59 ` Takashi Iwai
2004-11-22 18:59 ` [Alsa-devel] " Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2004-11-21 23:58 Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.