Re: Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

Re: Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

[Peter Zubaj]

[-- Attachment #1: Type: TEXT/plain, Size: 580 bytes --]

Is this what you wanted ???

Summary: Support for capture of 16,32,64 channels on emu10k1 device 2

This patch changes default constraint on "EFX voices mask" control and
allow capture of 1, 2, 4, 8, 16, 32, 64 channels instead of 1, 2, 4, 8.


Signed-off-by: Peter Zubaj <pzad@pobox.sk>

====================== REKLAMA ========================
Spolocnost SUN Microsystems uviedla na trh novy server Sun Fire V20z
zalozeny procesoroch AMD Opteron.
Viac informacii najdete na : http://www.somi.sk/sun/v20z.php
=======================================================

[-- Attachment #2: efx_channels.diff --]
[-- Type: APPLICATION/octet-stream, Size: 905 bytes --]

diff -u -r alsa-driver-1.0.6a-old/alsa-kernel/pci/emu10k1/emupcm.c alsa-driver-1.0.6a/alsa-kernel/pci/emu10k1/emupcm.c
--- alsa-driver-1.0.6a-old/alsa-kernel/pci/emu10k1/emupcm.c	2004-07-14 16:14:54.000000000 +0000
+++ alsa-driver-1.0.6a/alsa-kernel/pci/emu10k1/emupcm.c	2004-09-06 19:55:19.000000000 +0000
@@ -1092,6 +1092,7 @@
 	emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
 	unsigned int nval[2], bits;
 	int nefx = emu->audigy ? 64 : 32;
+	int nefxb = emu->audigy ? 7 : 6;
 	int change, idx;
 	
 	nval[0] = nval[1] = 0;
@@ -1100,8 +1101,14 @@
 			nval[idx / 32] |= 1 << (idx % 32);
 			bits++;
 		}
-	if (bits != 1 && bits != 2 && bits != 4 && bits != 8)
+		
+	for (idx = 0; idx < nefxb; idx++)
+		if (1 << idx == bits)
+			break;
+	
+	if (idx >= nefxb)
 		return -EINVAL;
+
 	spin_lock_irq(&emu->reg_lock);
 	change = (nval[0] != emu->efx_voices_mask[0]) ||
 		(nval[1] != emu->efx_voices_mask[1]);

Re: Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

[Takashi Iwai]

At Thu, 16 Sep 2004 10:08:32 +0200,
Peter Zubaj wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Is this what you wanted ???

Yes, thanks!
Now the patch was applied to CVS.


Takashi

> 
> Summary: Support for capture of 16,32,64 channels on emu10k1 device 2
> 
> This patch changes default constraint on "EFX voices mask" control and
> allow capture of 1, 2, 4, 8, 16, 32, 64 channels instead of 1, 2, 4, 8.
> 
> 
> Signed-off-by: Peter Zubaj <pzad@pobox.sk>
> 
> ====================== REKLAMA ========================
> Spolocnost SUN Microsystems uviedla na trh novy server Sun Fire V20z
> zalozeny procesoroch AMD Opteron.
> Viac informacii najdete na : http://www.somi.sk/sun/v20z.php
> =======================================================
> [2 efx_channels.diff <application/octet-stream (base64)>]
> 


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php

Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

[Peter Zubaj]

[-- Attachment #1: Type: TEXT/plain, Size: 450 bytes --]

Hi,

There is check for channel count (1,2,4,8).
Attached patch will add suppor for 16,32,64.

Could you test this ??? I tryed 32 and 64 channels an looks like it
works. I can not test (no time to do this) if recorded data are good.
Maybe if you remove this check completly hardware will work with 10
channels too, who know.

Peter Zubaj

____________________________________
http://www.logofun.pobox.sk - urobte radost svojmu telefonu

[-- Attachment #2: efx_channels.diff --]
[-- Type: APPLICATION/octet-stream, Size: 905 bytes --]

diff -u -r alsa-driver-1.0.6a-old/alsa-kernel/pci/emu10k1/emupcm.c alsa-driver-1.0.6a/alsa-kernel/pci/emu10k1/emupcm.c
--- alsa-driver-1.0.6a-old/alsa-kernel/pci/emu10k1/emupcm.c	2004-07-14 16:14:54.000000000 +0000
+++ alsa-driver-1.0.6a/alsa-kernel/pci/emu10k1/emupcm.c	2004-09-06 19:55:19.000000000 +0000
@@ -1092,6 +1092,7 @@
 	emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
 	unsigned int nval[2], bits;
 	int nefx = emu->audigy ? 64 : 32;
+	int nefxb = emu->audigy ? 7 : 6;
 	int change, idx;
 	
 	nval[0] = nval[1] = 0;
@@ -1100,8 +1101,14 @@
 			nval[idx / 32] |= 1 << (idx % 32);
 			bits++;
 		}
-	if (bits != 1 && bits != 2 && bits != 4 && bits != 8)
+		
+	for (idx = 0; idx < nefxb; idx++)
+		if (1 << idx == bits)
+			break;
+	
+	if (idx >= nefxb)
 		return -EINVAL;
+
 	spin_lock_irq(&emu->reg_lock);
 	change = (nval[0] != emu->efx_voices_mask[0]) ||
 		(nval[1] != emu->efx_voices_mask[1]);

Re: Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

[Lee Revell]

On Tue, 2004-09-07 at 03:18, Peter Zubaj wrote:
> Hi,
> 
> There is check for channel count (1,2,4,8).
> Attached patch will add suppor for 16,32,64.
> 
> Could you test this ??? I tryed 32 and 64 channels an looks like it
> works. I can not test (no time to do this) if recorded data are good.
> Maybe if you remove this check completly hardware will work with 10
> channels too, who know.

OK, it works (output from jackd):

registered builtin port type 32 bit float mono audio
loading driver ..
new client: alsa_pcm, id = 1 type 1 @ 0x8056858 fd = -1
creating alsa driver ... hw:0,0|hw:0,2|64|2|48000|0|0|nomon|swmeter|-|16bit
control device hw:0
configuring for 48000Hz, period = 64 frames, buffer = 2 periods
new buffer size 64
registered port alsa_pcm:capture_1, offset = 256
registered port alsa_pcm:capture_2, offset = 512
registered port alsa_pcm:capture_3, offset = 768
registered port alsa_pcm:capture_4, offset = 1024
registered port alsa_pcm:capture_5, offset = 1280
registered port alsa_pcm:capture_6, offset = 1536
registered port alsa_pcm:capture_7, offset = 1792
registered port alsa_pcm:capture_8, offset = 2048
registered port alsa_pcm:capture_9, offset = 2304
registered port alsa_pcm:capture_10, offset = 2560
registered port alsa_pcm:capture_11, offset = 2816
registered port alsa_pcm:capture_12, offset = 3072
registered port alsa_pcm:capture_13, offset = 3328
registered port alsa_pcm:capture_14, offset = 3584
registered port alsa_pcm:capture_15, offset = 3840
registered port alsa_pcm:capture_16, offset = 4096
registered port alsa_pcm:playback_1, offset = 0
registered port alsa_pcm:playback_2, offset = 0

It does not work unless the number of channels is a power of two. 
Here's what happens with 15 channels:

registered builtin port type 32 bit float mono audio
loading driver ..
new client: alsa_pcm, id = 1 type 1 @ 0x8056858 fd = -1
creating alsa driver ... hw:0,0|hw:0,2|64|2|48000|0|0|nomon|swmeter|-|16bit
control device hw:0
configuring for 48000Hz, period = 64 frames, buffer = 2 periods
ALSA: no playback configurations available (Invalid argument)
ALSA: cannot configure capture channel
cannot load driver module alsa

Since the allowed capture buffer sizes are fixed, this is the behavior I
would expect; seems like it makes the hardware design much easier.  kX
ASIO seems to use 16, probably because this works on both Audigy and
SBLive and gives you some playback voices left over for the wave devices
and MIDI synth.  It is also the smallest power of two that is guaranteed
to be more than the number of physical inputs or outputs.

Takashi-san, please apply Peter's patch to CVS.

Lee




-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m

Re: Re: [Alsa-user] Audigy multichannel and line-in did not work in Linux 2.6.7

[Takashi Iwai]

At Tue, 14 Sep 2004 23:13:50 -0400,
Lee Revell wrote:
> 
> Takashi-san, please apply Peter's patch to CVS.

Sure.  Peter, could you provide summary and description and
signed-off-by of your patch?


thanks,

Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m