From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Stefan Binding <sbinding@opensource.cirrus.com>,
Kailang Yang <kailang@realtek.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Jeremy Szu <jeremy.szu@canonical.com>,
linux-kernel@vger.kernel.org, tiwai@suse.com,
Werner Sembach <wse@tuxedocomputers.com>,
Hui Wang <hui.wang@canonical.com>,
Hans de Goede <hdegoede@redhat.com>, Sami Loone <sami@loone.fi>,
Cameron Berkenpas <cam@neo-zeon.de>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
Date: Fri, 18 Mar 2022 09:19:18 +0100 [thread overview]
Message-ID: <s5hee2z4qrd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220317221134.566358-1-kai.heng.feng@canonical.com>
On Thu, 17 Mar 2022 23:11:33 +0100,
Kai-Heng Feng wrote:
>
> Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> breaks mute and micmute LEDs because it changed the LED quirk from
> ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
> here.
>
> Also reorder the chain of quirks to ensure LED quirk is the last one
> being applied.
>
> Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Thanks, applied now.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
Jeremy Szu <jeremy.szu@canonical.com>,
Werner Sembach <wse@tuxedocomputers.com>,
Hui Wang <hui.wang@canonical.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Cameron Berkenpas <cam@neo-zeon.de>,
Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
Hans de Goede <hdegoede@redhat.com>,
Stefan Binding <sbinding@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
Date: Fri, 18 Mar 2022 09:19:18 +0100 [thread overview]
Message-ID: <s5hee2z4qrd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220317221134.566358-1-kai.heng.feng@canonical.com>
On Thu, 17 Mar 2022 23:11:33 +0100,
Kai-Heng Feng wrote:
>
> Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> breaks mute and micmute LEDs because it changed the LED quirk from
> ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
> here.
>
> Also reorder the chain of quirks to ensure LED quirk is the last one
> being applied.
>
> Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Thanks, applied now.
Takashi
next prev parent reply other threads:[~2022-03-18 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 22:11 [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9 Kai-Heng Feng
2022-03-17 22:11 ` Kai-Heng Feng
2022-03-18 8:19 ` Takashi Iwai [this message]
2022-03-18 8:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hee2z4qrd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cam@neo-zeon.de \
--cc=hdegoede@redhat.com \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=kai.heng.feng@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sami@loone.fi \
--cc=sbinding@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.