Re: [PATCH 15/51] ALSA: ens137x: Allocate resources with device-managed APIs

[Takashi Iwai <tiwai@suse.de>]

On Tue, 13 Jul 2021 17:23:26 +0200,
Amadeusz SX2awiX4ski wrote:
> 
> On 7/13/2021 4:28 PM, Takashi Iwai wrote:
> > This patch converts the resource management in PCI esn137x drivers
> > with devres as a clean up.  Each manual resource management is
> > converted with the corresponding devres helper, the devres helper is
> > used for the DMA buffer page allocations, and the card object release
> > is managed now via card->private_free instead of a lowlevel
> > snd_device.
> >
> > This should give no user-visible functional changes.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >   sound/pci/ens1370.c | 115 +++++++++++---------------------------------
> >   1 file changed, 27 insertions(+), 88 deletions(-)
> >
> > diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
> > index 728b69dad21b..2651f0c64c06 100644
> > --- a/sound/pci/ens1370.c
> > +++ b/sound/pci/ens1370.c
> > @@ -414,7 +414,7 @@ struct ensoniq {
> >   	unsigned int spdif_stream;
> >     #ifdef CHIP1370
> > -	struct snd_dma_buffer dma_bug;
> > +	struct snd_dma_buffer *dma_bug;
> 
> 
> You seem to touch all uses of this variable and it seems like it has a
> typo (dma_bug -> dms_buf),

Really?  I couldn't find it.


Takashi