CVS doesn't compile

CVS doesn't compile

[Martin Langer]

Sorry to say,

but CVS doesn't compile! Building the mixart driver fails:

make[3]: Entering directory /usr/local/src/alsa-cvs/alsa-driver/pci/mixart'
gcc -D__KERNEL__ -DMODULE=1 -I/usr/local/src/alsa-cvs/alsa-driver/include
-I/lib/modules/2.4.19-rc1/build/include -O2 -mpreferred-stack-boundary=2
-march=i686 -malign-functions=4 -DLINUX -Wall -Wstrict-prototypes
-fomit-frame-pointer -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -DALSA_BUILD  -DKBUILD_BASENAME=mixart   -c -o mixart.o mixart.c
In file included from mixart.c:35:
mixart_core.h:292: field streams' has incomplete type
make[3]: *** [mixart.o] Error 1
make[3]: Leaving directory /usr/local/src/alsa-cvs/alsa-driver/pci/mixart'
make[2]: *** [_modsubdir_mixart] Error 2
make[2]: Leaving directory /usr/local/src/alsa-cvs/alsa-driver/pci'
make[1]: *** [compile] Error 1


martin


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

RE: CVS doesn't compile

[Markus Bollinger]

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

Sorry,
I didnt know that compilers can get angry with [].
Use the attached patch.

What compiler version are you using ?

Markus.


-----Original Message-----
From:	Martin Langer [mailto:martin-langer@gmx.de]
Sent:	Sun 7/27/2003 11:36 AM
To:	alsa-devel@lists.sourceforge.net
Cc:	
Subject:	[Alsa-devel] CVS doesn't compile


Sorry to say,

but CVS doesn't compile! Building the mixart driver fails:

make[3]: Entering directory /usr/local/src/alsa-cvs/alsa-driver/pci/mixart'
gcc -D__KERNEL__ -DMODULE=1 -I/usr/local/src/alsa-cvs/alsa-driver/include
-I/lib/modules/2.4.19-rc1/build/include -O2 -mpreferred-stack-boundary=2
-march=i686 -malign-functions=4 -DLINUX -Wall -Wstrict-prototypes
-fomit-frame-pointer -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -DALSA_BUILD  -DKBUILD_BASENAME=mixart   -c -o mixart.o mixart.c
In file included from mixart.c:35:
mixart_core.h:292: field streams' has incomplete type
make[3]: *** [mixart.o] Error 1
make[3]: Leaving directory /usr/local/src/alsa-cvs/alsa-driver/pci/mixart'
make[2]: *** [_modsubdir_mixart] Error 2
make[2]: Leaving directory /usr/local/src/alsa-cvs/alsa-driver/pci'
make[1]: *** [compile] Error 1


martin


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff; name="patch", Size: 367 bytes --]

--- pci/mixart-cvs/mixart_core.h	2003-07-22 15:39:10.000000000 +0200
+++ pci/mixart/mixart_core.h	2003-07-28 09:30:19.000000000 +0200
@@ -289,7 +289,7 @@
 struct mixart_timer_notify
 {
 	u32                  stream_count;
-	mixart_sample_pos_t  streams[];
+	mixart_sample_pos_t  streams[MIXART_MAX_STREAM_PER_CARD * MIXART_MAX_CARDS];
 } __attribute__((packed));
 
 

Re: CVS doesn't compile

[Takashi Iwai]

At Mon, 28 Jul 2003 10:16:03 +0200,
Markus Bollinger wrote:
> 
> [1  <text/plain; Windows-1252 (quoted-printable)>]
> Sorry,
> I didnt know that compilers can get angry with [].

i didn't get error with gcc-3.3.  perhaps gcc-2.x only...?

> Use the attached patch.
 
or [1] would be enough, i believe.
for GCC, [0] is ok, too (although it's not strictly defined in ANSI).


Takashi


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

RE: CVS doesn't compile

[Markus Bollinger]

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Monday, July 28, 2003 11:27 AM
> To: Markus Bollinger
> Cc: Martin Langer; alsa-devel@lists.sourceforge.net; tiwai@suse.de
> Subject: Re: [Alsa-devel] CVS doesn't compile
> 
> 
> At Mon, 28 Jul 2003 10:16:03 +0200,
> Markus Bollinger wrote:
> > 
> > [1  <text/plain; Windows-1252 (quoted-printable)>]
> > Sorry,
> > I didnt know that compilers can get angry with [].
> 
> i didn't get error with gcc-3.3.  perhaps gcc-2.x only...?
> 
> > Use the attached patch.
>  
> or [1] would be enough, i believe.
> for GCC, [0] is ok, too (although it's not strictly defined in ANSI).


There is only once use of this stuct by a pointer to it,
so it makes no difference for the stack or the generated code.


Markus.


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

Re: CVS doesn't compile

[Martin Langer]

On Mon, Jul 28, 2003 at 11:26:59AM +0200, Takashi Iwai wrote:
> At Mon, 28 Jul 2003 10:16:03 +0200,
> Markus Bollinger wrote:
> > 
> > [1  <text/plain; Windows-1252 (quoted-printable)>]
> > Sorry,
> > I didnt know that compilers can get angry with [].
> 
> i didn't get error with gcc-3.3.  perhaps gcc-2.x only...?
> 

it's gcc 2.95.4 from debian woody

thanks for the fix,
martin


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01