All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Michael Catanzaro <mcatanzaro@redhat.com>
Cc: alsa-devel@alsa-project.org, "N,
	Harshapriya" <harshapriya.n@intel.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	kai.vehmanen@intel.com
Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio
Date: Fri, 29 Jan 2021 17:17:59 +0100	[thread overview]
Message-ID: <s5hft2jlnt4.wl-tiwai@suse.de> (raw)
In-Reply-To: <8CEPNQ.GAG87LR8RI871@redhat.com>

On Fri, 29 Jan 2021 17:12:08 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> <mcatanzaro@redhat.com> wrote:
> > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > Clevo machines" which was just merged yesterday. So I will test
> > again to find out.
> 
> Hi Takashi, hi Harsha,
> 
> I can confirm that the problem is fixed by this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851

Thanks, good to hear.

Then I think we can drop the entry from power_save_denylist in
hda_intel.c.  Could you try that it still works with the patch below?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
-	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Michael Catanzaro <mcatanzaro@redhat.com>
Cc: "N, Harshapriya" <harshapriya.n@intel.com>,
	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, kai.vehmanen@intel.com,
	stable@vger.kernel.org
Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio
Date: Fri, 29 Jan 2021 17:17:59 +0100	[thread overview]
Message-ID: <s5hft2jlnt4.wl-tiwai@suse.de> (raw)
In-Reply-To: <8CEPNQ.GAG87LR8RI871@redhat.com>

On Fri, 29 Jan 2021 17:12:08 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> <mcatanzaro@redhat.com> wrote:
> > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > Clevo machines" which was just merged yesterday. So I will test
> > again to find out.
> 
> Hi Takashi, hi Harsha,
> 
> I can confirm that the problem is fixed by this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851

Thanks, good to hear.

Then I think we can drop the entry from power_save_denylist in
hda_intel.c.  Could you try that it still works with the patch below?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
-	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */

  reply	other threads:[~2021-01-29 16:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 22:39 [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio Michael Catanzaro
2021-01-29  1:37 ` N, Harshapriya
2021-01-29  1:37   ` N, Harshapriya
2021-01-29  8:19   ` Takashi Iwai
2021-01-29 15:02   ` Michael Catanzaro
2021-01-29 15:06     ` Takashi Iwai
2021-01-29 15:27       ` Michael Catanzaro
2021-01-29 15:30         ` Michael Catanzaro
2021-01-29 16:12           ` Michael Catanzaro
2021-01-29 16:17             ` Takashi Iwai [this message]
2021-01-29 16:17               ` Takashi Iwai
2021-01-29 17:24               ` Michael Catanzaro
2021-01-29 17:24                 ` Michael Catanzaro
2021-01-29 18:56                 ` Takashi Iwai
2021-01-29 18:56                   ` Takashi Iwai
2021-08-14 14:02                   ` 藍挺瑋
2021-08-14 14:02                     ` 藍挺瑋
2021-08-15  9:20                     ` Takashi Iwai
2021-08-15  9:20                       ` Takashi Iwai
2021-08-16 16:57                       ` 藍挺瑋
2021-08-16 16:57                         ` 藍挺瑋
2021-08-17  5:25                         ` Takashi Iwai
2021-08-17  5:25                           ` Takashi Iwai
2021-02-01  4:24               ` Erich Ritz
2021-02-01  4:24                 ` Erich Ritz
2021-02-01 13:57                 ` Greg KH
2021-02-01 13:57                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hft2jlnt4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=harshapriya.n@intel.com \
    --cc=kai.vehmanen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcatanzaro@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.