BUG: Balance inverted on ppc with PowerMac DACA

BUG: Balance inverted on ppc with PowerMac DACA

[Frank Murphy]

I originally noticed this with ALSA 0.9.4, but it exists with ALSA 0.9.6 as 
well.

When playing sounds and adjusting the left/right balance, left is right and 
right is left. This is true in xmms as well as when using alsamixer.

I'm on Debain sid with default kernel-image-2.4.21-powerpc and alsa-base 
(0.9.6-2), alsa-modules-2 (0.9.6-1), alsa-source (0.9.6-2), and alsa-utils 
(0.9.6-1).

I should be able to do some testing, if needed.

Frank



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: BUG: Balance inverted on ppc with PowerMac DACA

[Frank Murphy]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On Friday 29 August 2003 5:13, Frank Murphy wrote:
> On Friday 29 August 2003 4:55, Frank Murphy wrote:
> > I'm on Debain sid with default kernel-image-2.4.21-powerpc and alsa-base
> > (0.9.6-2), alsa-modules-2 (0.9.6-1), alsa-source (0.9.6-2), and
> > alsa-utils (0.9.6-1).
>
> I forgot to say that I'm on an original Apple iBook and the module that
> gets loaded is snd-powermac. In alsamixer, it says "PowerMac DACA".
>
> Frank

So, I've located and fixed the problem. Left channel should have been 0, not 
1. Patch attached. Please apply.

Frank

[-- Attachment #2: daca.patch --]
[-- Type: text/x-diff, Size: 651 bytes --]

--- daca.c.dist	2003-09-01 13:01:57.000000000 +0200
+++ daca.c	2003-09-01 12:34:32.000000000 +0200
@@ -74,14 +74,14 @@
 	if (! mix->i2c.client)
 		return -ENODEV;
   
-	if (mix->right_vol > DACA_VOL_MAX)
+	if (mix->left_vol > DACA_VOL_MAX)
 		data[0] = DACA_VOL_MAX;
 	else
-		data[0] = mix->right_vol;
-	if (mix->left_vol > DACA_VOL_MAX)
+		data[0] = mix->left_vol;
+	if (mix->right_vol > DACA_VOL_MAX)
 		data[1] = DACA_VOL_MAX;
 	else
-		data[1] = mix->left_vol;
+		data[1] = mix->right_vol;
 	data[1] |= mix->deemphasis ? 0x40 : 0;
 	if (snd_pmac_keywest_write(&mix->i2c, DACA_REG_AVOL, 2, data) < 0) {
 		snd_printk("failed to set volume \n");  

Re: BUG: Balance inverted on ppc with PowerMac DACA

[Takashi Iwai]

At Mon, 1 Sep 2003 13:05:22 +0200,
Frank Murphy wrote:
> 
> [1  <text/plain; iso-8859-1 (7bit)>]
> On Friday 29 August 2003 5:13, Frank Murphy wrote:
> > On Friday 29 August 2003 4:55, Frank Murphy wrote:
> > > I'm on Debain sid with default kernel-image-2.4.21-powerpc and alsa-base
> > > (0.9.6-2), alsa-modules-2 (0.9.6-1), alsa-source (0.9.6-2), and
> > > alsa-utils (0.9.6-1).
> >
> > I forgot to say that I'm on an original Apple iBook and the module that
> > gets loaded is snd-powermac. In alsamixer, it says "PowerMac DACA".
> >
> > Frank
> 
> So, I've located and fixed the problem. Left channel should have been 0, not 
> 1. Patch attached. Please apply.

applied to cvs.
thanks!


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf