All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] snd-ice1712: Fix resume on ice1724
Date: Wed, 17 Oct 2012 08:57:39 +0200	[thread overview]
Message-ID: <s5hhapt7fh8.wl%tiwai@suse.de> (raw)
In-Reply-To: <1350241763-7248-6-git-send-email-linux@rainbow-software.org>

At Sun, 14 Oct 2012 21:09:23 +0200,
Ondrej Zary wrote:
> 
> set_pro_rate() is called from hw_params() but not from prepare(), breaking running PCM on suspend/resume.
> Call it from prepare() if PCM was suspended to fix the problem.
> 
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

This should be fixed in the resume callback.  Could you check the
patch below instead?


thanks,

Takashi

---
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 161c8f6..5cc3fa5 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2867,7 +2867,12 @@ static int snd_vt1724_resume(struct device *dev)
 		ice->set_spdif_clock(ice, 0);
 	} else {
 		/* internal on-card clock */
-		snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 1);
+		int rate;
+		if (ice->cur_rate)
+			rate = ice->cur_rate;
+		else
+			rate = ice->pro_rate_default;
+		snd_vt1724_set_pro_rate(ice, rate, 1);
 	}
 
 	update_spdif_bits(ice, ice->pm_saved_spdif_ctrl);

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 5/5] snd-ice1712: Fix resume on ice1724
Date: Wed, 17 Oct 2012 08:57:39 +0200	[thread overview]
Message-ID: <s5hhapt7fh8.wl%tiwai@suse.de> (raw)
In-Reply-To: <1350241763-7248-6-git-send-email-linux@rainbow-software.org>

At Sun, 14 Oct 2012 21:09:23 +0200,
Ondrej Zary wrote:
> 
> set_pro_rate() is called from hw_params() but not from prepare(), breaking running PCM on suspend/resume.
> Call it from prepare() if PCM was suspended to fix the problem.
> 
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

This should be fixed in the resume callback.  Could you check the
patch below instead?


thanks,

Takashi

---
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 161c8f6..5cc3fa5 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2867,7 +2867,12 @@ static int snd_vt1724_resume(struct device *dev)
 		ice->set_spdif_clock(ice, 0);
 	} else {
 		/* internal on-card clock */
-		snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 1);
+		int rate;
+		if (ice->cur_rate)
+			rate = ice->cur_rate;
+		else
+			rate = ice->pro_rate_default;
+		snd_vt1724_set_pro_rate(ice, rate, 1);
 	}
 
 	update_spdif_bits(ice, ice->pm_saved_spdif_ctrl);

  reply	other threads:[~2012-10-17  6:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-14 19:09 [PATCH 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-10-14 19:09 ` [PATCH 1/5] snd-ice1712: add chip_exit callback Ondrej Zary
2012-10-14 19:09   ` Ondrej Zary
2012-10-14 19:09 ` [PATCH 2/5] snd-ice1712: Add Wolfson Microelectronics WM8766 codec support Ondrej Zary
2012-10-14 19:09 ` [PATCH 3/5] snd-ice1712: Add Wolfson Microelectronics WM8776 " Ondrej Zary
2012-10-14 19:09 ` [PATCH 4/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-10-14 19:09 ` [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-10-17  6:57   ` Takashi Iwai [this message]
2012-10-17  6:57     ` [alsa-devel] " Takashi Iwai
2012-10-18 22:02     ` Ondrej Zary
2012-10-17  6:56 ` [alsa-devel] [PATCH 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2012-09-20 18:37 [RFC PATCH v3 " Ondrej Zary
2012-09-20 18:37 ` [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-09-20 18:37   ` Ondrej Zary
2012-09-18 18:58 [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-09-18 18:58 ` [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hhapt7fh8.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.