From: Takashi Iwai <tiwai@suse.de>
To: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] sound/pci/hda: Rename capture sources of CX20549 to match common conventions
Date: Thu, 05 Apr 2012 16:29:24 +0200 [thread overview]
Message-ID: <s5hhawyfe0r.wl%tiwai@suse.de> (raw)
In-Reply-To: <1333632606.4159.12.camel@localhost>
At Thu, 05 Apr 2012 15:30:06 +0200,
Michael Karcher wrote:
>
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 8c6523b..7d92aac 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -687,18 +687,18 @@ static const struct hda_channel_mode cxt5045_modes[1] = {
> static const struct hda_input_mux cxt5045_capture_source = {
> .num_items = 2,
> .items = {
> - { "IntMic", 0x1 },
> - { "ExtMic", 0x2 },
> + { "Internal Mic", 0x1 },
> + { "Mic", 0x2 },
> }
> };
>
> static const struct hda_input_mux cxt5045_capture_source_benq = {
> .num_items = 5,
> .items = {
> - { "IntMic", 0x1 },
> - { "ExtMic", 0x2 },
> - { "LineIn", 0x3 },
> { "CD", 0x4 },
> + { "Internal Mic", 0x1 },
> + { "Mic", 0x2 },
> + { "Line In", 0x3 },
This could be simply "Line".
Other than that, looks good.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] sound/pci/hda: Rename capture sources of CX20549 to match common conventions
Date: Thu, 05 Apr 2012 16:29:24 +0200 [thread overview]
Message-ID: <s5hhawyfe0r.wl%tiwai@suse.de> (raw)
In-Reply-To: <1333632606.4159.12.camel@localhost>
At Thu, 05 Apr 2012 15:30:06 +0200,
Michael Karcher wrote:
>
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 8c6523b..7d92aac 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -687,18 +687,18 @@ static const struct hda_channel_mode cxt5045_modes[1] = {
> static const struct hda_input_mux cxt5045_capture_source = {
> .num_items = 2,
> .items = {
> - { "IntMic", 0x1 },
> - { "ExtMic", 0x2 },
> + { "Internal Mic", 0x1 },
> + { "Mic", 0x2 },
> }
> };
>
> static const struct hda_input_mux cxt5045_capture_source_benq = {
> .num_items = 5,
> .items = {
> - { "IntMic", 0x1 },
> - { "ExtMic", 0x2 },
> - { "LineIn", 0x3 },
> { "CD", 0x4 },
> + { "Internal Mic", 0x1 },
> + { "Mic", 0x2 },
> + { "Line In", 0x3 },
This could be simply "Line".
Other than that, looks good.
Takashi
next prev parent reply other threads:[~2012-04-05 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 13:30 [PATCH 2/6] sound/pci/hda: Rename capture sources of CX20549 to match common conventions Michael Karcher
2012-04-05 14:29 ` Takashi Iwai [this message]
2012-04-05 14:29 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hhawyfe0r.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@mkarcher.dialup.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.