Re: [PATCH] alsa-driver: portman2x4 code cleanup

[Takashi Iwai <tiwai@suse.de>]

At Wed, 24 Jan 2007 20:43:46 +0100,
Matthias Koenig wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> >> Signed-off-by: Matthias Koenig <mkoenig@suse.de>
> >> ============================================================
> >> Summary: portman2x4 code cleanup
> >> 
> >> - changed code structure to mirror the one of the mts64.c driver 
> >>   for better maintenance
> >> - added proper handling of platform device
> >> - general cleanup (no CamelCase names)
> >
> > Thanks, the changes look good to me.
> >
> > Since the patch couldn't be applied cleanly, I fixed it manually.
> 
> Hmm, what was the problem? I just used the hg quilt extensions
> and took the resulting patch.

No idea yet...

> > Also, added cpu_relax() in busy loops, and fixed unneeded
> > initialization of variables.
> 
> Ok, thanks
> 
> > The code is now committed to ALSA HG tree.  Please give it a try.
> 
> Ah, I just tested and found that the rawmidi open/close callbacks
> have to be defined and cannot be NULL. So the driver as it is
> will oops if device will be opened.
> Fixed this, now tested with amidi input/output on all ports works
> fine. Patch is below.

Thanks, applied now.

> > BTW, if the driver works for you, we can move this to alsa-kernel tree
> > so that it's merged to the upstream kernel...
> 
> Great, yes I think it can then be moved to alsa-kernel tree.

OK, I'll work on this tomorrow.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV