Re: [PATCH] alsa-driver: portman2x4 code cleanup

[Takashi Iwai <tiwai@suse.de>]

At Wed, 24 Jan 2007 16:28:09 +0100,
Matthias Koenig wrote:
> 
> Hi,
> 
> here is the long announced cleanup of the portman2x4 driver code,
> please review.
> 
> Thanks,
> Matthias
> 
> Signed-off-by: Matthias Koenig <mkoenig@suse.de>
> ============================================================
> Summary: portman2x4 code cleanup
> 
> - changed code structure to mirror the one of the mts64.c driver 
>   for better maintenance
> - added proper handling of platform device
> - general cleanup (no CamelCase names)

Thanks, the changes look good to me.

Since the patch couldn't be applied cleanly, I fixed it manually.
Also, added cpu_relax() in busy loops, and fixed unneeded
initialization of variables.

The code is now committed to ALSA HG tree.  Please give it a try.


BTW, if the driver works for you, we can move this to alsa-kernel tree
so that it's merged to the upstream kernel...


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV