Re: [PATCH] Support for Audigy2 Value SB0400

[Takashi Iwai <tiwai@suse.de>]

At Mon, 22 Nov 2004 18:33:47 +0000,
James Courtier-Dutton wrote:
> 
> Takashi Iwai wrote:
> > At Mon, 22 Nov 2004 12:50:18 -0500,
> > Lee Revell wrote:
> > 
> >>On Mon, 2004-11-22 at 14:27 +0100, Takashi Iwai wrote:
> >>
> >>>The patch looks fine.  Could you provide the nice patch description
> >>>and the signed-off-by lines?
> >>
> >>Also, I noticed the patch contains some /proc changes.  Care to comment
> >>a little on these?  I was also planning to improve the /proc support,
> >>but don't want to duplicate any work.
> > 
> > 
> > Yep, at best, the patch should be splitting three parts with summary,
> > descrption and signed-off-by lines for each:
> > 
> > - fix for snd_emu10k1_compose_audigy_*() macros
> > - addition of Audigy2 Value support
> > - addition to proc for register dump
> > 
> > 
> > James, could you do this?
> > 
> > thanks,
> > 
> > Takashi
> > 
> > 
> 
> I could, but it will have to wait till next weekend.
> The register dump should only happen if the driver is built with 
> CONFIG_SND_DEBUG switched on.

Hmm, ok I committed the audigy_fxrt* fix and the audigy2 value
support.  The patch to emuproc.c isn't committed yet since this would
conflict with Lee's work.

Lee, please let me know if it's better to merge James's patch
beforehand.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/