From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: James Courtier-Dutton <James@superbug.co.uk>,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Support for Audigy2 Value SB0400
Date: Mon, 22 Nov 2004 18:59:46 +0100 [thread overview]
Message-ID: <s5hmzx9vk6l.wl@alsa2.suse.de> (raw)
In-Reply-To: <1101145818.2873.6.camel@krustophenia.net>
At Mon, 22 Nov 2004 12:50:18 -0500,
Lee Revell wrote:
>
> On Mon, 2004-11-22 at 14:27 +0100, Takashi Iwai wrote:
> > The patch looks fine. Could you provide the nice patch description
> > and the signed-off-by lines?
>
> Also, I noticed the patch contains some /proc changes. Care to comment
> a little on these? I was also planning to improve the /proc support,
> but don't want to duplicate any work.
Yep, at best, the patch should be splitting three parts with summary,
descrption and signed-off-by lines for each:
- fix for snd_emu10k1_compose_audigy_*() macros
- addition of Audigy2 Value support
- addition to proc for register dump
James, could you do this?
thanks,
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
next prev parent reply other threads:[~2004-11-22 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 2:03 [PATCH] Support for Audigy2 Value SB0400 James Courtier-Dutton
2004-11-22 13:27 ` Takashi Iwai
2004-11-22 17:50 ` Lee Revell
2004-11-22 17:59 ` Takashi Iwai [this message]
2004-11-22 18:33 ` James Courtier-Dutton
2004-11-22 18:48 ` Takashi Iwai
2004-11-23 0:11 ` Lee Revell
2004-11-23 15:13 ` Takashi Iwai
2004-11-22 18:28 ` James Courtier-Dutton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmzx9vk6l.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=James@superbug.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.