From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>,
Tong Zhang <ztong0001@gmail.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Huilong Deng <denghuilong@cdjrlc.com>,
Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>,
Jasmin Fazlic <superfassl@gmail.com>
Subject: Re: [PATCH] ALSA: hdsp: fix a test for copy_to_user() failure
Date: Tue, 22 Jun 2021 21:33:46 +0200 [thread overview]
Message-ID: <s5him25pucl.wl-tiwai@suse.de> (raw)
In-Reply-To: <YNIzqpVR6L2t/RwJ@mwanda>
On Tue, 22 Jun 2021 21:02:02 +0200,
Dan Carpenter wrote:
>
> The copy_to_user() function returns the number of bytes remaining to be
> copied. It doesn't return negatives.
>
> Fixes: 66c8f75919dd ("ALSA: hdsp: Fix assignment in if condition")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jasmin Fazlic <superfassl@gmail.com>,
Romain Perier <romain.perier@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Huilong Deng <denghuilong@cdjrlc.com>,
Tong Zhang <ztong0001@gmail.com>,
Allen Pais <allen.lkml@gmail.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: hdsp: fix a test for copy_to_user() failure
Date: Tue, 22 Jun 2021 21:33:46 +0200 [thread overview]
Message-ID: <s5him25pucl.wl-tiwai@suse.de> (raw)
In-Reply-To: <YNIzqpVR6L2t/RwJ@mwanda>
On Tue, 22 Jun 2021 21:02:02 +0200,
Dan Carpenter wrote:
>
> The copy_to_user() function returns the number of bytes remaining to be
> copied. It doesn't return negatives.
>
> Fixes: 66c8f75919dd ("ALSA: hdsp: Fix assignment in if condition")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
next prev parent reply other threads:[~2021-06-22 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 19:02 [PATCH] ALSA: hdsp: fix a test for copy_to_user() failure Dan Carpenter
2021-06-22 19:02 ` Dan Carpenter
2021-06-22 19:33 ` Takashi Iwai [this message]
2021-06-22 19:33 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5him25pucl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=allen.lkml@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=denghuilong@cdjrlc.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=romain.perier@gmail.com \
--cc=superfassl@gmail.com \
--cc=tiwai@suse.com \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.