From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v2 1/2] ALSA: oxfw: remove an unnecessary condition in hwdep_read()
Date: Mon, 25 Jan 2021 14:51:19 +0100 [thread overview]
Message-ID: <s5him7l3z1k.wl-tiwai@suse.de> (raw)
In-Reply-To: <YA6ntkBxT/4DJ4YK@mwanda>
On Mon, 25 Jan 2021 12:12:54 +0100,
Dan Carpenter wrote:
>
> Smatch complains that "count" isn't clamped properly and
> "oxfw->dev_lock_changed" is false then it leads to an information
> leak. But it turns out that "oxfw->dev_lock_changed" is always
> set and the condition can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: this version just removes the condition
Applied now. Thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v2 1/2] ALSA: oxfw: remove an unnecessary condition in hwdep_read()
Date: Mon, 25 Jan 2021 13:51:19 +0000 [thread overview]
Message-ID: <s5him7l3z1k.wl-tiwai@suse.de> (raw)
In-Reply-To: <YA6ntkBxT/4DJ4YK@mwanda>
On Mon, 25 Jan 2021 12:12:54 +0100,
Dan Carpenter wrote:
>
> Smatch complains that "count" isn't clamped properly and
> "oxfw->dev_lock_changed" is false then it leads to an information
> leak. But it turns out that "oxfw->dev_lock_changed" is always
> set and the condition can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: this version just removes the condition
Applied now. Thanks.
Takashi
next prev parent reply other threads:[~2021-01-25 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:10 [PATCH] ALSA: fireface: fix info leak in hwdep_read() Dan Carpenter
2021-01-21 6:10 ` Dan Carpenter
2021-01-21 20:42 ` Christophe JAILLET
2021-01-21 20:42 ` Christophe JAILLET
2021-01-22 7:13 ` Dan Carpenter
2021-01-22 7:13 ` Dan Carpenter
2021-01-25 11:12 ` [PATCH v2 1/2] ALSA: oxfw: remove an unnecessary condition " Dan Carpenter
2021-01-25 11:12 ` Dan Carpenter
2021-01-25 13:46 ` Takashi Sakamoto
2021-01-25 13:46 ` Takashi Sakamoto
2021-01-25 13:51 ` Takashi Iwai [this message]
2021-01-25 13:51 ` Takashi Iwai
2021-01-25 11:13 ` [PATCH v2 2/2] ALSA: fireface: remove " Dan Carpenter
2021-01-25 11:13 ` Dan Carpenter
2021-01-25 13:45 ` Takashi Sakamoto
2021-01-25 13:45 ` Takashi Sakamoto
2021-01-25 13:51 ` Takashi Iwai
2021-01-25 13:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5him7l3z1k.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.