All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	alsa-devel@alsa-project.org, Evan Quan <evan.quan@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
Date: Tue, 12 Jan 2021 16:00:24 +0100	[thread overview]
Message-ID: <s5him82qjxz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210105175245.963451-1-alexander.deucher@amd.com>

On Tue, 05 Jan 2021 18:52:45 +0100,
Alex Deucher wrote:
> 
> We are able to power down the GPU and audio via the GPU driver
> so flag these asics as supporting runtime pm.
> 
> Reviewed-by: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

I wanted to apply this one now, but noticed that the author address
(gmail) is different from your S-o-b address (amd.com).
Alex, is this intentional and keep it, or should I correct the author
address?


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index d539f52009a1..2ea46b5a9a23 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = {
>  	  .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
>  	/* ATI HDMI */
>  	{ PCI_DEVICE(0x1002, 0x0002),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0x1308),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
>  	{ PCI_DEVICE(0x1002, 0x157a),
> @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = {
>  	{ PCI_DEVICE(0x1002, 0xaab0),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
>  	{ PCI_DEVICE(0x1002, 0xaac0),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0xaac8),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0xaad8),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
>  	  AZX_DCAPS_PM_RUNTIME },
> -- 
> 2.29.2
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	alsa-devel@alsa-project.org, Evan Quan <evan.quan@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
Date: Tue, 12 Jan 2021 16:00:24 +0100	[thread overview]
Message-ID: <s5him82qjxz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210105175245.963451-1-alexander.deucher@amd.com>

On Tue, 05 Jan 2021 18:52:45 +0100,
Alex Deucher wrote:
> 
> We are able to power down the GPU and audio via the GPU driver
> so flag these asics as supporting runtime pm.
> 
> Reviewed-by: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

I wanted to apply this one now, but noticed that the author address
(gmail) is different from your S-o-b address (amd.com).
Alex, is this intentional and keep it, or should I correct the author
address?


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index d539f52009a1..2ea46b5a9a23 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = {
>  	  .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
>  	/* ATI HDMI */
>  	{ PCI_DEVICE(0x1002, 0x0002),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0x1308),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
>  	{ PCI_DEVICE(0x1002, 0x157a),
> @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = {
>  	{ PCI_DEVICE(0x1002, 0xaab0),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
>  	{ PCI_DEVICE(0x1002, 0xaac0),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0xaac8),
> -	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	{ PCI_DEVICE(0x1002, 0xaad8),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
>  	  AZX_DCAPS_PM_RUNTIME },
> -- 
> 2.29.2
> 

  reply	other threads:[~2021-01-12 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 17:52 [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio Alex Deucher
2021-01-05 17:52 ` Alex Deucher
2021-01-12 15:00 ` Takashi Iwai [this message]
2021-01-12 15:00   ` Takashi Iwai
2021-01-12 15:03   ` Alex Deucher
2021-01-12 15:03     ` Alex Deucher
2021-01-12 15:06     ` Takashi Iwai
2021-01-12 15:06       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5him82qjxz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.