All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rander Wang <rander.wang@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda: Fix a headphone detection issue when using SOF
Date: Mon, 01 Jul 2019 16:14:58 +0200	[thread overview]
Message-ID: <s5himsl6dul.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190701074630.51472-1-rander.wang@linux.intel.com>

On Mon, 01 Jul 2019 09:46:30 +0200,
Rander Wang wrote:
> 
> To save power, the hda hdmi driver in ASoC invokes snd_hdac_ext_bus_link_put
> to disable CORB/RIRB buffers DMA if there is no user of bus and invokes
> snd_hdac_ext_bus_link_get to set up CORB/RIRB buffers when it is used.
> Unsolicited responses is disabled in snd_hdac_bus_stop_cmd_io called by
> snd_hdac_ext_bus_link_put , but it is not enabled in snd_hdac_bus_init_cmd_io
> called by snd_hdac_ext_bus_link_get. So for put-get sequence, Unsolicited
> responses is disabled and headphone can't be detected by hda codecs.
> 
> Now unsolicited responses is only enabled in snd_hdac_bus_reset_link
> which resets controller. The function is only called for setup of
> controller. This patch enables Unsolicited responses after RIRB is
> initialized in snd_hdac_bus_init_cmd_io which works together with
> snd_hdac_bus_reset_link to set up controller.
> 
> Tested legacy hda driver and SOF driver on intel whiskeylake.
> 
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Rander Wang <rander.wang@linux.intel.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2019-07-01 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01  7:46 [PATCH] ALSA: hda: Fix a headphone detection issue when using SOF Rander Wang
2019-07-01 14:14 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5himsl6dul.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=rander.wang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.