All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
Date: Mon, 18 Sep 2017 15:39:28 +0200	[thread overview]
Message-ID: <s5hinggi0rz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170913230116.yspku7ov2hgqtigh@mwanda>

On Thu, 14 Sep 2017 01:01:16 +0200,
Dan Carpenter wrote:
> 
> The "info.index" variable represents a bit in hw->dsp_loaded which is
> an unsigned int.  If it's higher than 31 we hit a shift wrapping bug.
> This seems harmless, but I wanted to silence the static checker warning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
Date: Mon, 18 Sep 2017 13:39:28 +0000	[thread overview]
Message-ID: <s5hinggi0rz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170913230116.yspku7ov2hgqtigh@mwanda>

On Thu, 14 Sep 2017 01:01:16 +0200,
Dan Carpenter wrote:
> 
> The "info.index" variable represents a bit in hw->dsp_loaded which is
> an unsigned int.  If it's higher than 31 we hit a shift wrapping bug.
> This seems harmless, but I wanted to silence the static checker warning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi

  reply	other threads:[~2017-09-18 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 23:01 [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug Dan Carpenter
2017-09-13 23:01 ` Dan Carpenter
2017-09-18 13:39 ` Takashi Iwai [this message]
2017-09-18 13:39   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hinggi0rz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.