From: Takashi Iwai <tiwai@suse.de>
To: Wang YanQing <udknight@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe
Date: Sun, 03 Sep 2017 16:36:48 +0200 [thread overview]
Message-ID: <s5hingzvofz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170903141122.GA2848@udknight>
On Sun, 03 Sep 2017 16:11:22 +0200,
Wang YanQing wrote:
>
> When hda_codec_driver_probe meet error and return failure, we need
> to free resource with patch_ops.free, or we will get resource leak.
No, the codec driver is responsible to free resources in its error
path.
thanks,
Takashi
prev parent reply other threads:[~2017-09-03 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 14:11 [PATCH] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe Wang YanQing
2017-09-03 14:36 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hingzvofz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.