From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: patches.audio@intel.com, Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v2 3/7] ALSA: hda - Use hdmi name space for CEA spk alloc structure
Date: Wed, 02 Mar 2016 17:09:48 +0100 [thread overview]
Message-ID: <s5hio14svxv.wl-tiwai@suse.de> (raw)
In-Reply-To: <1456920208-1172-4-git-send-email-subhransu.s.prusty@intel.com>
On Wed, 02 Mar 2016 13:03:24 +0100,
Subhransu S. Prusty wrote:
>
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
A slight concern is that the code we have is specific to HD-audio
while the header and symbols don't indicate it in your patch.
If it were designed for a generic purpose HDMI/DP, it's fine. But the
current code appears fairly specific to HDA, so it should be a bit
more uniquely prefixed, I suppose, since there are some other parallel
developments regarding HDMI for other platforms.
thanks,
Takashi
next prev parent reply other threads:[~2016-03-02 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 12:03 [PATCH v2 0/7] ALSA: hda: Move chmap helpers to core Subhransu S. Prusty
2016-03-02 12:03 ` [PATCH v2 1/7] ALSA: hda - Create common chmap object Subhransu S. Prusty
2016-03-02 12:03 ` [PATCH v2 2/7] ALSA: hda - Register chmap obj as priv data instead of codec Subhransu S. Prusty
2016-03-02 16:05 ` Takashi Iwai
2016-03-02 12:03 ` [PATCH v2 3/7] ALSA: hda - Use hdmi name space for CEA spk alloc structure Subhransu S. Prusty
2016-03-02 16:09 ` Takashi Iwai [this message]
2016-03-02 12:03 ` [PATCH v2 4/7] ALSA: hda - Add hdmi chmap verb programming ops to chmap object Subhransu S. Prusty
2016-03-02 12:03 ` [PATCH v2 5/7] ALSA: hda - Use ops instead of directly accessing chmap helpers Subhransu S. Prusty
2016-03-02 16:03 ` Takashi Iwai
2016-03-03 11:29 ` Vinod Koul
2016-03-03 11:39 ` Takashi Iwai
2016-03-03 11:54 ` Subhransu S. Prusty
2016-03-03 13:37 ` Takashi Iwai
2016-03-02 12:03 ` [PATCH v2 6/7] ALSA: hda - Move chmap support helpers/ops to core Subhransu S. Prusty
2016-03-02 12:03 ` [PATCH v2 7/7] ALSA: hda - Use snd_hdmi namespace prefix for printing ch alloc api Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hio14svxv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.