Re: [PATCH v2 2/7] ALSA: hda - Register chmap obj as priv data instead of codec

[Takashi Iwai <tiwai@suse.de>]

On Wed, 02 Mar 2016 13:03:23 +0100,
Subhransu S. Prusty wrote:
> 
> With this chmap object is added as private data and new ops are
> added to access driver specific chmap.
> 
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
>  include/sound/hdmi_chmap.h |   6 +++
>  sound/pci/hda/patch_hdmi.c | 100 ++++++++++++++++++++++++++++++---------------
>  2 files changed, 72 insertions(+), 34 deletions(-)
> 
> diff --git a/include/sound/hdmi_chmap.h b/include/sound/hdmi_chmap.h
> index 32087f1..c7702ef9 100644
> --- a/include/sound/hdmi_chmap.h
> +++ b/include/sound/hdmi_chmap.h
> @@ -30,6 +30,12 @@ struct hdmi_chmap_ops {
>  
>  	/* check that the user-given chmap is supported */
>  	int (*chmap_validate)(int ca, int channels, unsigned char *chmap);
> +
> +	void (*get_chmap)(struct hdac_device *hdac, int pcm_idx,
> +					unsigned char *chmap);
> +	void (*set_chmap)(struct hdac_device *hdac, int pcm_idx,
> +			unsigned char *chmap, int prepared);
> +	bool (*is_monitor_connected)(struct hdac_device *hdac, int pcm_idx);

This name is rather confusing.  Actually, this function doesn't mean
the monitor connected state.  It indicates rather whether any pin is
assigned to the given PCM.  It may return false only for devices with
dynamic PCM assignment.  For the rest, it's always true.


Takashi