* [PATCH] ppc32: Small build fix for alsa powermac
@ 2005-05-02 1:40 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-05-02 1:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel list, Linus Torvalds, alsa-devel
Hi !
My newer iMac mini driver doesn't build with verbose debug enabled. This
fixes it, and removes an erroneous error printk (since it's normal on
some machine to not find some gpios on the "first try").
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/sound/ppc/toonie.c
===================================================================
--- linux-work.orig/sound/ppc/toonie.c 2005-05-02 10:51:00.000000000 +1000
+++ linux-work/sound/ppc/toonie.c 2005-05-02 11:38:22.000000000 +1000
@@ -279,8 +279,7 @@
if (! base) {
base = (u32 *)get_property(np, "reg", NULL);
if (!base) {
- DBG("(E) cannot find address for device %s !\n", device);
- snd_printd("cannot find address for device %s\n", device);
+ DBG("(E) cannot find address for device %s !\n", name);
return -ENODEV;
}
addr = *base;
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ppc32: Small build fix for alsa powermac
@ 2005-05-02 1:40 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-05-02 1:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel list, Linus Torvalds, alsa-devel
Hi !
My newer iMac mini driver doesn't build with verbose debug enabled. This
fixes it, and removes an erroneous error printk (since it's normal on
some machine to not find some gpios on the "first try").
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/sound/ppc/toonie.c
===================================================================
--- linux-work.orig/sound/ppc/toonie.c 2005-05-02 10:51:00.000000000 +1000
+++ linux-work/sound/ppc/toonie.c 2005-05-02 11:38:22.000000000 +1000
@@ -279,8 +279,7 @@
if (! base) {
base = (u32 *)get_property(np, "reg", NULL);
if (!base) {
- DBG("(E) cannot find address for device %s !\n", device);
- snd_printd("cannot find address for device %s\n", device);
+ DBG("(E) cannot find address for device %s !\n", name);
return -ENODEV;
}
addr = *base;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Alsa-devel] [PATCH] ppc32: Small build fix for alsa powermac
2005-05-02 1:40 ` Benjamin Herrenschmidt
(?)
@ 2005-05-12 13:07 ` Takashi Iwai
-1 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2005-05-12 13:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andrew Morton, Linux Kernel list, Linus Torvalds, alsa-devel
Hi Ben,
At Mon, 02 May 2005 11:40:30 +1000,
Benjamin Herrenschmidt wrote:
>
> Hi !
>
> My newer iMac mini driver doesn't build with verbose debug enabled. This
> fixes it, and removes an erroneous error printk (since it's normal on
> some machine to not find some gpios on the "first try").
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied to ALSA tree now. Thanks!
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-12 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-02 1:40 [PATCH] ppc32: Small build fix for alsa powermac Benjamin Herrenschmidt
2005-05-02 1:40 ` Benjamin Herrenschmidt
2005-05-12 13:07 ` [Alsa-devel] " Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.