From: Takashi Iwai <tiwai@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] ALSA ISA drivers: misc cleanups
Date: Thu, 25 Nov 2004 16:20:30 +0100 [thread overview]
Message-ID: <s5his7unef5.wl@alsa2.suse.de> (raw)
In-Reply-To: <20041124232758.GP19873@stusta.de>
At Thu, 25 Nov 2004 00:27:58 +0100,
Adrian Bunk wrote:
>
> The patch below makes cleanups under sound/isa/ including:
> - make needlessly global code static
> - ad1816a/ad1816a_lib.c: much code was unused starting with the
> global function snd_ad1816a_timer
I prefer disabling this to removal (in case somone wants to add the
timer function).
> - removed EXPORT_SYMBOL's:
> - cs423x/cs4231_lib.c: snd_cs4231_outm
> - es1688/es1688_lib.c: snd_es1688_mixer_read
>
> Please review this patch.
Otherwise looks fine.
Applied it to ALSA tree. Thanks!
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [Alsa-devel] [2.6 patch] ALSA ISA drivers: misc cleanups
Date: Thu, 25 Nov 2004 16:20:30 +0100 [thread overview]
Message-ID: <s5his7unef5.wl@alsa2.suse.de> (raw)
In-Reply-To: <20041124232758.GP19873@stusta.de>
At Thu, 25 Nov 2004 00:27:58 +0100,
Adrian Bunk wrote:
>
> The patch below makes cleanups under sound/isa/ including:
> - make needlessly global code static
> - ad1816a/ad1816a_lib.c: much code was unused starting with the
> global function snd_ad1816a_timer
I prefer disabling this to removal (in case somone wants to add the
timer function).
> - removed EXPORT_SYMBOL's:
> - cs423x/cs4231_lib.c: snd_cs4231_outm
> - es1688/es1688_lib.c: snd_es1688_mixer_read
>
> Please review this patch.
Otherwise looks fine.
Applied it to ALSA tree. Thanks!
Takashi
next prev parent reply other threads:[~2004-11-25 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 23:27 [2.6 patch] ALSA ISA drivers: misc cleanups Adrian Bunk
2004-11-24 23:27 ` Adrian Bunk
2004-11-25 15:20 ` Takashi Iwai [this message]
2004-11-25 15:20 ` [Alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5his7unef5.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.