From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Pavel Machek <pavel@ucw.cz>, John Mock <kd6pag@qsl.net>,
linux-kernel@vger.kernel.org, perex@suse.cz,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3
Date: Mon, 22 Nov 2004 12:58:02 +0100 [thread overview]
Message-ID: <s5his7ydrjp.wl@alsa2.suse.de> (raw)
In-Reply-To: <1100977903.6879.56.camel@krustophenia.net>
At Sat, 20 Nov 2004 14:11:42 -0500,
Lee Revell wrote:
>
> Please cc: alsa-devel on ALSA issues (we now allow posts from non
> subscribers! :-P).
It's a known problem and already fixed on ALSA CVS.
Sice 2.6.10-rc2, pci_save_state() is no longer called as default when
suspend callback is set. The patch is below.
Takashi
--- linux/sound/core/init.c 8 Nov 2004 11:37:08 -0000 1.48
+++ linux/sound/core/init.c 12 Nov 2004 13:56:32 -0000
@@ -782,12 +782,15 @@
int snd_card_pci_suspend(struct pci_dev *dev, u32 state)
{
snd_card_t *card = pci_get_drvdata(dev);
+ int err;
if (! card || ! card->pm_suspend)
return 0;
if (card->power_state == SNDRV_CTL_POWER_D3hot)
return 0;
/* FIXME: correct state value? */
- return card->pm_suspend(card, 0);
+ err = card->pm_suspend(card, 0);
+ pci_save_state(dev);
+ return err;
}
int snd_card_pci_resume(struct pci_dev *dev)
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Pavel Machek <pavel@ucw.cz>, John Mock <kd6pag@qsl.net>,
linux-kernel@vger.kernel.org, perex@suse.cz,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3
Date: Mon, 22 Nov 2004 12:58:02 +0100 [thread overview]
Message-ID: <s5his7ydrjp.wl@alsa2.suse.de> (raw)
In-Reply-To: <1100977903.6879.56.camel@krustophenia.net>
At Sat, 20 Nov 2004 14:11:42 -0500,
Lee Revell wrote:
>
> Please cc: alsa-devel on ALSA issues (we now allow posts from non
> subscribers! :-P).
It's a known problem and already fixed on ALSA CVS.
Sice 2.6.10-rc2, pci_save_state() is no longer called as default when
suspend callback is set. The patch is below.
Takashi
--- linux/sound/core/init.c 8 Nov 2004 11:37:08 -0000 1.48
+++ linux/sound/core/init.c 12 Nov 2004 13:56:32 -0000
@@ -782,12 +782,15 @@
int snd_card_pci_suspend(struct pci_dev *dev, u32 state)
{
snd_card_t *card = pci_get_drvdata(dev);
+ int err;
if (! card || ! card->pm_suspend)
return 0;
if (card->power_state == SNDRV_CTL_POWER_D3hot)
return 0;
/* FIXME: correct state value? */
- return card->pm_suspend(card, 0);
+ err = card->pm_suspend(card, 0);
+ pci_save_state(dev);
+ return err;
}
int snd_card_pci_resume(struct pci_dev *dev)
next prev parent reply other threads:[~2004-11-22 11:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 16:58 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3 John Mock
2004-11-20 18:51 ` Pavel Machek
2004-11-20 19:11 ` Lee Revell
2004-11-22 11:58 ` Takashi Iwai [this message]
2004-11-22 11:58 ` Takashi Iwai
2004-11-30 0:35 ` Andrew Morton
2004-11-30 10:22 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2004-12-02 19:24 Tovar
2004-12-02 17:49 John Mock
2004-12-02 19:10 ` Andrew Morton
2004-12-02 8:51 John Mock
2004-12-02 10:25 ` Pavel Machek
2004-12-02 14:48 ` Russell King
2004-12-13 10:13 ` Russell King
2004-11-19 1:05 John Mock
2004-11-19 2:26 ` Benjamin Herrenschmidt
2004-11-18 22:49 John Mock
2004-11-18 23:17 ` Benjamin Herrenschmidt
2004-11-19 11:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5his7ydrjp.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=kd6pag@qsl.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@suse.cz \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.