Re: [PATCH/RFC] emu10k1 multichannel PCM

[Takashi Iwai <tiwai@suse.de>]

At Wed, 17 Nov 2004 01:22:56 -0500,
Lee Revell wrote:
> 
> [1  <text/plain (7bit)>]
> On Sat, 2004-11-13 at 23:18 -0500, Lee Revell wrote:
> > On Fri, 2004-11-12 at 18:07 -0500, Lee Revell wrote:
> > > This patch is still missing a few things, like dynamic voice allocation
> > > and correctly setting the send routing, but it does work with JACK, and
> > > should not interfere with the operation of the other devices.   I tested
> > > it like so:
> > 
> > Here is a patch that adds the mixer controls for this device.
> 
> Here is the latest version.  This fixes the send routing and mixer
> controls.  Among other things there was a copy and paste bug in
> emumixer.c.
> 
> I have tested this one with JACK and Hydrogen, it actually works better
> at 64 frames than it did with separate capture/playback interrupts.
> 
> The patch is up to 1200 lines or so.  It should not get much longer.
> There are still some bugs; this is not ready to commit yet but getting
> close.
> 
> Signed-Off-By: Lee Revell <rlrevell@joe-job.com>

We still need to discuss the mixer handling, but otherwise the
implementation seems ok to me.

The code looks alsmot fine.  Please keep the 8-letter tab stop for
indentation, and be careful about the compatibility with the older gcc
such as variable definition in the middle of the function.

I expect that debug prints will be eliminated in the final version,
right?


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8