[PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.

[PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.

[Benny Sjostrand]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

Hi!

Once again, updated cs46xx patch.
So, here's a attempt to move stuff from snd_cs46xx_playback_prepare(...),
to snd_cs46xx_hw_params(...), thing works,  but I dont like the aproach,
the main reason is that snd_cs46xx_hw_params(...) is not a good place
for adjusting the sample rate. I've noticed that some OSS applications
the hw_params is called upto 3 times, and I've found a way to find
out when actually the sample rate is set to the value the application
is going to proceed with.


Summary of changes:
- Rear PCM channel
- IEC958 PCM channel
- Turn on Amplifier and setup EGPIO for Santa Cruz card on init
- Fixed voyetra typo  on request  ("voyectra" -> "voyetra")
- Turn ON the HBP bit in SERBCF register, in the cs4630 spec. it
  says that it should be ON to access the FIFO via the backdoors.
- More cleanups in voyetra_setup_eapd_slot(...), same aproach as
   in snd_cs46xx_clear_serial_FIFOs(...), both functions access
    the FIFO's and basically in the same way.
- Some minor cleanups in snd_cs46xx_clear_serial_FIFOs(...)
- Move SCB stuff from snd_cs46xx_playback_prepare(...) to 
snd_cs46xx_playback_hw_params(...)
  course mutexes cant be used in prepare(...)

/Benny

[-- Attachment #2: cs46xx.patch.gz --]
[-- Type: application/postscript, Size: 10162 bytes --]

patch download (was: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.)

[Benny Sjostrand]

Hi!

Seems like the attachment in my last mail for some reason have been 
corrupted.

My last patch is available for download at: 
http://www.cucumelo.org/~gorm/cs46xx.patch.gz

/Benny



-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en

Re: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.

[Takashi Iwai]

At Thu, 31 Oct 2002 01:01:36 +0100,
Benny Sjostrand wrote:
> 
> Hi!
> 
> Once again, updated cs46xx patch.
> So, here's a attempt to move stuff from snd_cs46xx_playback_prepare(...),
> to snd_cs46xx_hw_params(...), thing works,  but I dont like the aproach,
> the main reason is that snd_cs46xx_hw_params(...) is not a good place
> for adjusting the sample rate. I've noticed that some OSS applications
> the hw_params is called upto 3 times, and I've found a way to find
> out when actually the sample rate is set to the value the application
> is going to proceed with.

thanks, applied to cvs now.

basically, prepare may be called also mutliple times by OSS emulation,
so the situation is identical.
on OSS, you _have to_ change the rate many times.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en

Re: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.

[Benny Sjostrand]

> thanks, applied to cvs now.
>

Looks good except that you forgot to apply the changes related to
cs46xx.c, or the rear and IEC958 PCM wont be activated.

/Benny





-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en

Re: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.

[Takashi Iwai]

At Thu, 31 Oct 2002 16:12:22 +0100 (CET),
Benny Sjostrand wrote:
> 
> > thanks, applied to cvs now.
> >
> 
> Looks good except that you forgot to apply the changes related to
> cs46xx.c, or the rear and IEC958 PCM wont be activated.

d'oh...

thanks for your notince.
now committed.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en