[PATCH] rme32 fullduplex fix

[PATCH] rme32 fullduplex fix

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]


Kudos to Takashi and Pilo!

Fullduplex (using module option 'fullduplex=1') works now on rme32 :)
Please commit the attached patch, which fixes a strange bug.


Thanks!
martin


-- 
                                     Living on earth may be expensive,
                   but it includes an annual free trip around the sun. 

[-- Attachment #2: fix.diff --]
[-- Type: text/plain, Size: 1436 bytes --]

--- alsa-kernel/pci/rme32.c.ORIGINAL	Sat Jul 17 18:48:43 2004
+++ alsa-kernel/pci/rme32.c	Sat Jul 17 20:37:58 2004
@@ -1,7 +1,8 @@
 /*
  *   ALSA driver for RME Digi32, Digi32/8 and Digi32 PRO audio interfaces
  *
- *	Copyright (c) 2002, 2003 Martin Langer <martin-langer@gmx.de>
+ *      Copyright (c) 2002-2004 Martin Langer <martin-langer@gmx.de>,
+ *                              Pilo Chambert <pilo.c@wanadoo.fr>
  *
  *      Thanks to :        Anders Torger <torger@ludd.luth.se>,
  *                         Henk Hesselink <henk@anda.nl>
@@ -101,7 +102,7 @@
 MODULE_PARM_DESC(enable, "Enable RME Digi32 soundcard.");
 module_param_array(fullduplex, bool, boot_devs, 0444);
 MODULE_PARM_DESC(fullduplex, "Support full-duplex mode.");
-MODULE_AUTHOR("Martin Langer <martin-langer@gmx.de>");
+MODULE_AUTHOR("Martin Langer <martin-langer@gmx.de>, Pilo Chambert <pilo.c@wanadoo.fr>");
 MODULE_DESCRIPTION("RME Digi32, Digi32/8, Digi32 PRO");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{RME,Digi32}," "{RME,Digi32/8}," "{RME,Digi32 PRO}}");
@@ -153,7 +154,7 @@
 #define RME32_WCR_BITPOS_INP_1 7
 
 /* Read control register bits */
-#define RME32_RCR_AUDIO_ADDR_MASK 0x10001
+#define RME32_RCR_AUDIO_ADDR_MASK 0x1ffff
 #define RME32_RCR_LOCK      (1 << 23)   /* 1=locked, 0=not locked */
 #define RME32_RCR_ERF       (1 << 26)   /* 1=Error, 0=no Error */
 #define RME32_RCR_FREQ_0    (1 << 27)   /* CS841x frequency (record) */

Re: [PATCH] rme32 fullduplex fix

[Takashi Iwai]

At Sat, 17 Jul 2004 21:05:54 +0200,
Martin Langer wrote:
> 
> Kudos to Takashi and Pilo!
> 
> Fullduplex (using module option 'fullduplex=1') works now on rme32 :)
> Please commit the attached patch, which fixes a strange bug.

Thanks, applied now.

Meanwhile, I fixed another possible bug (capture overflow) on cvs.
Please wait for a while until sf's tree is synced.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click