Re: Re: [PATCH] USB MIDI driver

[Takashi Iwai <tiwai@suse.de>]

At Wed, 03 Jul 2002 14:52:13 +0200,
Clemens Ladisch wrote:
> 
> Takashi Iwai wrote:
> > - newly added virmidi registrations.
> >   that means, snd-usb-midi will have its own rawmidi devices
> >   automatically as /dev/snd/midiCxDx.
> >   this will be good for applications which speak only with
> >   rawmidi.
> > 
> > the latter one was not tested.
> > can anyone update the cvs if it works?
> 
> Using the cable number as index for the rawmidi device will not work
> if there is more than one endpoint (I don't think such a device exists;
> my driver supports more than one endpoint only because the OSS and
> NetBSD drivers do).
> 
> I changed it to use the sequencer port number instead.
> 
> There are devices with more output than input ports (e.g. MU1000),
> and virmidi with SNDRV_VIRMIDI_SEQ_ATTACH doesn't support input anyway,

hmm, this mode wasn't tested, too.  usb-midi is the first case.
doesn't rawmidi read work at all?

> so I moved the rmidi pointer from usbmidi_in_port to usbmidi_out_port.
> (The virmidi device applies to both input and output ports, so,
> theoretically, it should go into a usbmidi_endpoint structure. That
> one hasn't been needed until now.)

yep. 


anyway, the patch is applied.  thanks.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
No, I will not fix your computer.
http://thinkgeek.com/sf